From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Christoph Hellwig <hch@infradead.org>
Cc: Sergey Panov <sipan@sipan.org>,
Stefan Richter <stefanr@s5r6.in-berlin.de>,
linux-scsi@vger.kernel.org,
Linux Kernel <linux-kernel@vger.kernel.org>,
Jeff Garzik <jgarzik@pobox.com>,
Luben Tuikov <luben_tuikov@adaptec.com>,
andrew.patterson@hp.com, Christoph Hellwig <hch@lst.de>,
"Moore, Eric Dean" <Eric.Moore@lsil.com>,
jejb@steeleye.com, Linus Torvalds <torvalds@osdl.org>
Subject: Re: ioctls, etc. (was Re: [PATCH 1/4] sas: add flag for locally attached PHYs)
Date: Sat, 22 Oct 2005 19:27:55 +0100 [thread overview]
Message-ID: <1130005675.15961.37.camel@localhost.localdomain> (raw)
In-Reply-To: <20051022171943.GA7546@infradead.org>
On Sad, 2005-10-22 at 18:19 +0100, Christoph Hellwig wrote:
> No. Rewriting something from scratch is horrible engineering practice.
There I must disagree strongly. There are times when it is the right
thing to do because the original is unsalvagable (see drivers/ide).
OTOH I do not believe the scsi layer is in this state.
Luben, it isn't about layering. Linux does layering and does it strongly
but it does not do unneccessary layering. If the layer above is wrong
then adapt it step by step without breaking existing stuff (or making
sure the existing changes to drivers are clean and testable).
That process works. There is very little left of the original "Linux"
and most of what is left is the stuff that most needs maintenance (eg
floppy.c, tty layer). In time they too will change.
Don't go around the scsi layer for something generic, go through it.
Going around things or adding ugly hacks is fine (and justified) for a
specific single piece of hardware that is somehow brain damaged, its not
the right approach for something likely to be mainstream and generic.
next prev parent reply other threads:[~2005-10-22 18:00 UTC|newest]
Thread overview: 83+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-20 15:25 [PATCH 1/4] sas: add flag for locally attached PHYs Moore, Eric Dean
2005-10-20 15:55 ` Luben Tuikov
2005-10-20 16:01 ` Christoph Hellwig
2005-10-20 16:51 ` Luben Tuikov
2005-10-20 17:03 ` Christoph Hellwig
2005-10-20 17:22 ` Arjan van de Ven
2005-10-20 20:10 ` Luben Tuikov
2005-10-21 8:16 ` Arjan van de Ven
2005-10-20 20:02 ` Luben Tuikov
2005-10-21 0:01 ` Andrew Patterson
2005-10-21 0:46 ` ioctls, etc. (was Re: [PATCH 1/4] sas: add flag for locally attached PHYs) Jeff Garzik
2005-10-21 5:09 ` Mike Christie
2005-10-21 5:41 ` Douglas Gilbert
2005-10-21 6:19 ` Jeff Garzik
2005-10-21 18:37 ` Luben Tuikov
2005-10-21 17:48 ` Luben Tuikov
2005-10-21 18:04 ` Christoph Hellwig
2005-10-21 18:12 ` Luben Tuikov
2005-10-21 18:20 ` Matthew Wilcox
2005-10-22 2:30 ` Douglas Gilbert
2005-10-22 2:54 ` Jeff Garzik
2005-10-22 3:53 ` Jeff Garzik
2005-10-22 17:14 ` Luben Tuikov
2005-10-22 17:49 ` Francois Romieu
2005-10-22 16:51 ` Luben Tuikov
2005-10-21 18:18 ` Jeff Garzik
2005-10-21 18:50 ` Luben Tuikov
2005-10-21 18:54 ` Jeff Garzik
2005-10-21 19:13 ` Luben Tuikov
2005-10-21 19:23 ` Jeff Garzik
2005-10-21 22:20 ` Stefan Richter
2005-10-21 19:22 ` Luben Tuikov
2005-10-21 19:39 ` Jeff Garzik
2005-10-21 20:41 ` Luben Tuikov
2005-10-21 21:12 ` Jeff Garzik
2005-10-21 21:24 ` Luben Tuikov
2005-10-21 21:41 ` Jeff Garzik
2005-10-21 22:14 ` Luben Tuikov
2005-10-21 22:43 ` Jeff Garzik
2005-10-22 9:26 ` Stefan Richter
2005-10-22 17:23 ` Luben Tuikov
2005-10-22 10:42 ` Stefan Richter
2005-10-22 10:58 ` Christoph Hellwig
2005-10-22 15:28 ` Sergey Panov
2005-10-22 17:19 ` Christoph Hellwig
2005-10-22 17:38 ` Sergey Panov
2005-10-24 15:18 ` Luben Tuikov
2005-10-22 18:27 ` Alan Cox [this message]
2005-10-24 13:51 ` Luben Tuikov
2005-10-24 15:41 ` Alan Cox
2005-10-24 15:14 ` Luben Tuikov
2005-10-24 16:03 ` Regala
2005-10-24 16:13 ` Luben Tuikov
2005-10-24 16:04 ` Regala
2005-10-22 17:30 ` Luben Tuikov
2005-10-22 18:19 ` Jeff Garzik
2005-10-22 17:49 ` Stefan Richter
2005-10-24 22:09 ` ioctls, etc. (was Re: [PATCH 1/4] sas: add flag for locally attachedPHYs) David Lang
2005-10-24 23:09 ` Stefan Richter
2005-10-22 11:12 ` David Lang
2005-10-22 17:39 ` Luben Tuikov
2005-10-22 17:41 ` Stefan Richter
2005-10-22 17:51 ` Christoph Hellwig
2005-10-22 18:21 ` Stefan Richter
2005-10-22 18:39 ` Sergey Panov
2005-10-22 13:27 ` ioctls, etc. (was Re: [PATCH 1/4] sas: add flag for locally attached PHYs) Stefan Richter
2005-10-22 16:09 ` Luben Tuikov
2005-10-21 19:41 ` Matthew Wilcox
2005-10-21 19:48 ` Luben Tuikov
2005-10-21 19:54 ` Matthew Wilcox
2005-10-21 20:05 ` Luben Tuikov
2005-10-21 19:46 ` Arjan van de Ven
2005-10-21 19:50 ` Luben Tuikov
2005-10-21 9:06 ` [PATCH 1/4] sas: add flag for locally attached PHYs Arjan van de Ven
2005-10-21 17:05 ` Andrew Patterson
2005-10-21 17:18 ` Arjan van de Ven
2005-10-21 18:57 ` Luben Tuikov
2005-10-21 17:32 ` Luben Tuikov
2005-10-21 1:50 ` Douglas Gilbert
2005-10-21 2:16 ` Jeff Garzik
2005-10-21 3:25 ` Douglas Gilbert
2005-10-21 18:04 ` Luben Tuikov
-- strict thread matches above, loose matches on Subject: below --
2005-10-21 20:31 ioctls, etc. (was Re: [PATCH 1/4] sas: add flag for locally attached PHYs) Salyzyn, Mark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1130005675.15961.37.camel@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=Eric.Moore@lsil.com \
--cc=andrew.patterson@hp.com \
--cc=hch@infradead.org \
--cc=hch@lst.de \
--cc=jejb@steeleye.com \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=luben_tuikov@adaptec.com \
--cc=sipan@sipan.org \
--cc=stefanr@s5r6.in-berlin.de \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox