public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: James Bottomley <James.Bottomley@SteelEye.com>
Cc: akpm@osdl.org, linux-scsi@vger.kernel.org
Subject: Re: [patch 2/5] scsi_error thread exits in TASK_INTERRUPTIBLE state.
Date: Fri, 28 Oct 2005 18:28:22 -0400	[thread overview]
Message-ID: <1130538502.6169.21.camel@localhost.localdomain> (raw)
In-Reply-To: <1130538105.3328.21.camel@mulgrave>

On Fri, 2005-10-28 at 17:21 -0500, James Bottomley wrote:
> On Fri, 2005-10-28 at 15:07 -0700, akpm@osdl.org wrote:
> > From: Steven Rostedt <rostedt@goodmis.org>
> > 
> > Found in the -rt patch set.  The scsi_error thread likely will be in the
> > TASK_INTERRUPTIBLE state upon exit.  This patch fixes this bug.
> > 
> > Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
> > Cc: James Bottomley <James.Bottomley@steeleye.com>
> > Signed-off-by: Andrew Morton <akpm@osdl.org>
> > ---
> > 
> >  drivers/scsi/scsi_error.c |    1 +
> >  1 files changed, 1 insertion(+)
> > 
> > diff -puN drivers/scsi/scsi_error.c~scsi_error-thread-exits-in-task_interruptible-state drivers/scsi/scsi_error.c
> > --- 25/drivers/scsi/scsi_error.c~scsi_error-thread-exits-in-task_interruptible-state	Fri Oct 28 15:06:03 2005
> > +++ 25-akpm/drivers/scsi/scsi_error.c	Fri Oct 28 15:06:03 2005
> > @@ -1644,6 +1644,7 @@ int scsi_error_handler(void *data)
> >  		scsi_restart_operations(shost);
> >  		set_current_state(TASK_INTERRUPTIBLE);
> >  	}
> > +	__set_current_state(TASK_RUNNING);
> ^^^^^^^^^^^^^^^^^^^^^
> >  	__set_current_state(TASK_RUNNING);
> ^^^^^^^^^^^^^^^^^^^^^
> 
> Mismerge, I think (of a patch which is already present)

Yeah, I noticed that Linus pulled it into the 2.6.14 release, since it
was a small minor fix. So this can be dropped.

-- Steve



      reply	other threads:[~2005-10-28 22:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-10-28 22:07 [patch 2/5] scsi_error thread exits in TASK_INTERRUPTIBLE state akpm
2005-10-28 22:21 ` James Bottomley
2005-10-28 22:28   ` Steven Rostedt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1130538502.6169.21.camel@localhost.localdomain \
    --to=rostedt@goodmis.org \
    --cc=James.Bottomley@SteelEye.com \
    --cc=akpm@osdl.org \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox