From: James Bottomley <James.Bottomley@SteelEye.com>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: linux-scsi@vger.kernel.org
Subject: Re: [scsi hcil 3/9] misc cleanups
Date: Fri, 28 Oct 2005 20:34:19 -0500 [thread overview]
Message-ID: <1130549660.3328.35.camel@mulgrave> (raw)
In-Reply-To: <20051024220205.GC10567@havoc.gtf.org>
On Mon, 2005-10-24 at 18:02 -0400, Jeff Garzik wrote:
> - eliminate use of 'channel' and 'id' in starget_for_each_device()
Actually, we can't do this. The reason for the way it looks today is
that shost_for_each_device() actually performs a lot of magic assuming
that the list can be changing under it (it was a long precursor to the
klists, if you like). list_for_each_entry() does no such magic.
We could convert to klists to get this, or simply replicate the host
magic per target.
James
next prev parent reply other threads:[~2005-10-29 1:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-24 22:00 [scsi hcil 0/9] marginalize HCIL a bit Jeff Garzik
2005-10-24 22:01 ` [scsi hcil 1/9] kill unused scsi_scan_single_target() Jeff Garzik
2005-10-24 22:01 ` [scsi hcil 2/9] remove cpqfcTS driver, long uncompilable Jeff Garzik
2005-10-24 22:02 ` [scsi hcil 3/9] misc cleanups Jeff Garzik
2005-10-29 1:34 ` James Bottomley [this message]
2005-10-24 22:02 ` [scsi hcil 4/9] s/scsi_scan_target/spi_scan_target/ Jeff Garzik
2005-10-24 22:03 ` [scsi hcil 5/9] split up __spi_scan_target() Jeff Garzik
2005-10-24 22:03 ` [scsi hcil 6/9] introduce sfoo_printk, sfoo_id, sfoo_channel helpers Jeff Garzik
2005-10-24 22:04 ` [scsi hcil 7/9] use {sdev,scmd,starget,shost}_printk in generic code Jeff Garzik
2005-10-24 22:04 ` [scsi hcil 8/9] use sfoo_printk() in drivers Jeff Garzik
2005-10-24 22:05 ` [scsi hcil 9/9] use scmd_id(), scmd_channel() throughout code Jeff Garzik
2005-10-24 22:30 ` [scsi hcil 10/9] ibmmca bug fix Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1130549660.3328.35.camel@mulgrave \
--to=james.bottomley@steeleye.com \
--cc=jgarzik@pobox.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox