Re: [usb-storage] [Merging ATA passthru] on integrating SMART/ATA-Security in usb-storage driver

Mike Anderson
2005-11-08T23:05:30Z

Alan Stern <stern@rowland.harvard.edu> wrote:
> ===================================================================
> --- usb-2.6.orig/include/scsi/scsi_device.h
> +++ usb-2.6/include/scsi/scsi_device.h
> @@ -161,7 +161,8 @@ struct scsi_target {
> unsigned int channel;
> unsigned int id; /* target id ... replace
> * scsi_device.id eventually */
> - unsigned long create:1; /* signal that it needs to be added */
> + unsigned int create:1; /* signal that it needs to be added */
> + unsigned int no_report_lun:1; /* do not use REPORT LUNS */
> char scsi_level;
> void *hostdata; /* available to low-level driver */
> unsigned long starget_data[0]; /* for the transport */

Alan,

Instead of adding a new bit field to scsi_target could we utilize bflags
in the scsi_target. Currently we have sdev_bflags in the scsi_device which
we are not utilizing. We could remove sdev_bflags and add a bflags to
scsi_target

In the usb slave configure we could "or" in BLIST_NOREPORTLUN.

Then in the function scsi_get_device_flags we could reference the
scsi_target bflags instead of sdev_bflags.

The bflags check in scsi_scan.c for BLIST_NOREPORTLUN could stay the same
and we would not have two flags for a similar no report luns check.

-andmike
--
Michael Anderson
andmike@us.ibm.com