From: James Bottomley <James.Bottomley@SteelEye.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-kernel@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
dgilbert@interlog.com, linux-scsi@vger.kernel.org
Subject: Re: [PATCH 12/25] scsi: move SG_IO ioctl32 code to sg.c
Date: Sat, 05 Nov 2005 10:44:59 -0600 [thread overview]
Message-ID: <1131209099.3614.7.camel@mulgrave> (raw)
In-Reply-To: <20051105162715.367344000@b551138y.boeblingen.de.ibm.com>
On Sat, 2005-11-05 at 17:27 +0100, Arnd Bergmann wrote:
> plain text document attachment (sg-ioctl.diff)
> The sg driver already has a compat_ioctl function, so the
> conversion handler for SG_IO can easily be moved in there
> as well. It still uses compat_alloc_user_space, so it can
> probably be simplified by using merging the conversion
> handler with the native method.
This is the wrong place, isn't it? SG_IO is also in
drivers/block/scsi_ioctl.c which isn't modular, so shouldn't this be in
there?
James
next prev parent reply other threads:[~2005-11-05 16:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-05 16:26 [PATCH 00/25] reduce code in fs/compat_ioctl.c Arnd Bergmann
2005-11-05 16:27 ` [PATCH 12/25] scsi: move SG_IO ioctl32 code to sg.c Arnd Bergmann
2005-11-05 16:44 ` James Bottomley [this message]
2005-11-05 19:19 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1131209099.3614.7.camel@mulgrave \
--to=james.bottomley@steeleye.com \
--cc=arnd@arndb.de \
--cc=dgilbert@interlog.com \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).