From: James Bottomley <James.Bottomley@SteelEye.com>
To: Daniel Drake <dsd@gentoo.org>
Cc: Neela.Kolli@engenio.com, Christoph Hellwig <hch@infradead.org>,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH resend] Allow both megaraid drivers to be built
Date: Sun, 06 Nov 2005 12:47:59 -0600 [thread overview]
Message-ID: <1131302879.3316.13.camel@mulgrave> (raw)
In-Reply-To: <436377F8.3060505@gentoo.org>
On Sat, 2005-10-29 at 14:24 +0100, Daniel Drake wrote:
> Here's a rediff of a patch I sent at the end of August.
>
> Rename megaraid to megaraid_legacy, changing sysfs name, module
> name, and the messages printed out via printk. I have left the procfs name as
> "megaraid" as presumably userspace tools rely on this.
>
> Remove hardware ID's from megaraid_legacy which overlap with the newgen
> megaraid drivers.
>
> Allow megaraid_legacy to be built alongside the newgen driver.
>
> Instead of renaming the file locally and sending a huge unreviewable diff,
> I've left the original filenames (megaraid.c and megaraid.h) in place. Please
> use git-mv to rename these to megaraid_legacy.[ch] once you have applied this.
This looks fine to me. I would, however, like input from the megaraid
maintainers, since it actually involves a name change. However, if
there are no comments before we got -rc, I'll queue it for after 2.6.15
James
next prev parent reply other threads:[~2005-11-06 18:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-29 13:24 [PATCH resend] Allow both megaraid drivers to be built Daniel Drake
2005-11-06 18:47 ` James Bottomley [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-11-07 6:05 Bagalkote, Sreenivas
2005-11-07 6:15 ` Christoph Hellwig
2005-11-07 14:14 ` Daniel Drake
2005-11-07 6:41 Bagalkote, Sreenivas
2005-11-07 11:36 ` 'Christoph Hellwig'
2005-11-07 13:22 ` James Bottomley
2005-11-07 14:09 Bagalkote, Sreenivas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1131302879.3316.13.camel@mulgrave \
--to=james.bottomley@steeleye.com \
--cc=Neela.Kolli@engenio.com \
--cc=dsd@gentoo.org \
--cc=hch@infradead.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).