From: James Bottomley <James.Bottomley@SteelEye.com>
To: "Moore, Eric Dean" <Eric.Moore@lsil.com>
Cc: SCSI Mailing List <linux-scsi@vger.kernel.org>, hch@lst.de
Subject: RE: [RFC] raid class support for mptfusion
Date: Mon, 07 Nov 2005 17:02:36 -0500 [thread overview]
Message-ID: <1131400957.3333.3.camel@mulgrave> (raw)
In-Reply-To: <91888D455306F94EBD4D168954A9457C04CDA56F@nacos172.co.lsil.com>
On Mon, 2005-11-07 at 14:50 -0700, Moore, Eric Dean wrote:
> > On Sunday, November 06, 2005 11:03 AM, James Bottomley wrote:
> >
>
>
> > @@ -2598,24 +2544,6 @@ mptscsih_event_process(MPT_ADAPTER *ioc,
> > break;
> >
> > case MPI_EVENT_INTEGRATED_RAID: /* 0B */
> > - {
> > - pMpiEventDataRaid_t pRaidEventData =
> > - (pMpiEventDataRaid_t) pEvReply->Data;
> > -#ifdef MPTSCSIH_ENABLE_DOMAIN_VALIDATION
> > - /* Domain Validation Needed */
> > - if (ioc->bus_type == SCSI &&
> > - pRaidEventData->ReasonCode ==
> > - MPI_EVENT_RAID_RC_DOMAIN_VAL_NEEDED)
> > - mptscsih_set_dvflags_raid(hd,
> > pRaidEventData->PhysDiskNum);
> > -#endif
> > - break;
> > - }
> > -
>
>
> I forgot to mention in previous email, we can't just delete
> the handling of MPI_EVENT_RAID_RC_DOMAIN_VAL_NEEDED asyn event.
>
> Someone that has a degraded fault tolerant array, such as RAID1 or
> RAID1E, will have poor performance(asyn narrow) once they replace the failed
> drive with an optimal drive. This event is needed so when the new
> drive is added, we can perform domain validation on the hidden disk.
> Thus James, can you handle notifying the spi transport layer of this new
> disk?
Yes, easily ... this looks like some type of mismerge, since I was sure
I had the integrated raid DV even hooked directly into domain
validation. I can add it, though.
James
next prev parent reply other threads:[~2005-11-07 22:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-07 21:50 [RFC] raid class support for mptfusion Moore, Eric Dean
2005-11-07 22:02 ` James Bottomley [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-11-07 20:25 Moore, Eric Dean
2005-11-06 18:03 James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1131400957.3333.3.camel@mulgrave \
--to=james.bottomley@steeleye.com \
--cc=Eric.Moore@lsil.com \
--cc=hch@lst.de \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox