From: James Bottomley <James.Bottomley@SteelEye.com>
To: Patrick Mansfield <patmans@us.ibm.com>
Cc: "goggin, edward" <egoggin@emc.com>,
'Rolf Eike Beer' <eike-kernel@sf-tec.de>,
'Andrew Morton' <akpm@osdl.org>,
Masanari Iida <standby24x7@gmail.com>,
linux-kernel@vger.kernel.org,
linux-usb-devel@lists.sourceforge.net,
linux-scsi@vger.kernel.org
Subject: Re: oops with USB Storage on 2.6.14
Date: Tue, 08 Nov 2005 16:45:54 -0500 [thread overview]
Message-ID: <1131486354.3270.42.camel@mulgrave> (raw)
In-Reply-To: <20051108213306.GA25219@us.ibm.com>
On Tue, 2005-11-08 at 13:33 -0800, Patrick Mansfield wrote:
> I mean we get a ref to the sdev in the upper level driver opens, scan, and
> sd flush. So where are we not getting a ref?
>
> Shouldn't the get be done at a higher level?
Actually, no, because of the way we run the queues for the next command.
If this is a sd_sync_cache() or something for the last possible command
on the device, the process may have a reference to the device, but as
soon as we call end_that_request_last(), they may be racing to release
it. The bug is triggered when we get into scsi_next_command() with us
holding the only remaining reference to the device.
James
next prev parent reply other threads:[~2005-11-08 21:45 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-08 20:02 oops with USB Storage on 2.6.14 goggin, edward
2005-11-08 21:08 ` James Bottomley
2005-11-08 21:33 ` Patrick Mansfield
2005-11-08 21:45 ` James Bottomley [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-12-07 3:29 goggin, edward
2005-11-08 18:02 goggin, edward
2005-11-08 16:24 goggin, edward
2005-11-08 16:38 ` Rolf Eike Beer
2005-11-08 17:01 ` James Bottomley
[not found] <38bdcd1f0510290511t65bb16cfkfd1e84fb301424f9@mail.gmail.com>
2005-10-30 19:03 ` Andrew Morton
[not found] ` <38bdcd1f0510301641l3a211e41n3c571a98eef6185e@mail.gmail.com>
2005-10-31 1:02 ` Andrew Morton
2005-11-08 4:40 ` Andrew Morton
2005-11-08 15:01 ` Masanari Iida
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1131486354.3270.42.camel@mulgrave \
--to=james.bottomley@steeleye.com \
--cc=akpm@osdl.org \
--cc=egoggin@emc.com \
--cc=eike-kernel@sf-tec.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-usb-devel@lists.sourceforge.net \
--cc=patmans@us.ibm.com \
--cc=standby24x7@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox