* [PATCH] lpfc: Timer fix
@ 2005-12-16 21:16 Mark Haverkamp
2005-12-21 17:39 ` James Smart
0 siblings, 1 reply; 4+ messages in thread
From: Mark Haverkamp @ 2005-12-16 21:16 UTC (permalink / raw)
To: James.Smart@Emulex.Com; +Cc: linux-scsi
James,
I've been doing some testing with the lpfc driver and started running
into some BUG_ON problems using add_timer in lpfc_els_timeout_handler.
I'm not certain, but I think that the add_timer call should be a
mod_timer.
Please take a look.
Signed-of-by: Mark Haverkamp <markh@osdl.org>
---
Index: scsi-misc-2.6/drivers/scsi/lpfc/lpfc_els.c
===================================================================
--- scsi-misc-2.6.orig/drivers/scsi/lpfc/lpfc_els.c 2005-12-16 13:14:37.000000000 -0800
+++ scsi-misc-2.6/drivers/scsi/lpfc/lpfc_els.c 2005-12-16 13:14:53.000000000 -0800
@@ -2935,8 +2935,7 @@
lpfc_sli_release_iocbq(phba, piocb);
}
if (phba->sli.ring[LPFC_ELS_RING].txcmplq_cnt) {
- phba->els_tmofunc.expires = jiffies + HZ * timeout;
- add_timer(&phba->els_tmofunc);
+ mod_timer(&phba->els_tmofunc, jiffies + HZ * timeout);
}
spin_unlock_irq(phba->host->host_lock);
}
--
Mark Haverkamp <markh@osdl.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] lpfc: Timer fix
2005-12-16 21:16 [PATCH] lpfc: Timer fix Mark Haverkamp
@ 2005-12-21 17:39 ` James Smart
2005-12-21 18:25 ` James Bottomley
0 siblings, 1 reply; 4+ messages in thread
From: James Smart @ 2005-12-21 17:39 UTC (permalink / raw)
To: Mark Haverkamp; +Cc: linux-scsi
Agreed.
-- james s
Mark Haverkamp wrote:
> James,
>
> I've been doing some testing with the lpfc driver and started running
> into some BUG_ON problems using add_timer in lpfc_els_timeout_handler.
> I'm not certain, but I think that the add_timer call should be a
> mod_timer.
> Please take a look.
>
> Signed-of-by: Mark Haverkamp <markh@osdl.org>
>
> ---
>
> Index: scsi-misc-2.6/drivers/scsi/lpfc/lpfc_els.c
> ===================================================================
> --- scsi-misc-2.6.orig/drivers/scsi/lpfc/lpfc_els.c 2005-12-16 13:14:37.000000000 -0800
> +++ scsi-misc-2.6/drivers/scsi/lpfc/lpfc_els.c 2005-12-16 13:14:53.000000000 -0800
> @@ -2935,8 +2935,7 @@
> lpfc_sli_release_iocbq(phba, piocb);
> }
> if (phba->sli.ring[LPFC_ELS_RING].txcmplq_cnt) {
> - phba->els_tmofunc.expires = jiffies + HZ * timeout;
> - add_timer(&phba->els_tmofunc);
> + mod_timer(&phba->els_tmofunc, jiffies + HZ * timeout);
> }
> spin_unlock_irq(phba->host->host_lock);
> }
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] lpfc: Timer fix
2005-12-21 17:39 ` James Smart
@ 2005-12-21 18:25 ` James Bottomley
2005-12-21 18:45 ` James Smart
0 siblings, 1 reply; 4+ messages in thread
From: James Bottomley @ 2005-12-21 18:25 UTC (permalink / raw)
To: James.Smart; +Cc: Mark Haverkamp, linux-scsi
On Wed, 2005-12-21 at 12:39 -0500, James Smart wrote:
> Agreed.
Is this critical for 2.6.15 or can it wait until after 2.6.15 is
released?
James
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] lpfc: Timer fix
2005-12-21 18:25 ` James Bottomley
@ 2005-12-21 18:45 ` James Smart
0 siblings, 0 replies; 4+ messages in thread
From: James Smart @ 2005-12-21 18:45 UTC (permalink / raw)
To: James Bottomley; +Cc: Mark Haverkamp, linux-scsi
I would assume it's ok to wait until after 2.6.15.
-- james s
James Bottomley wrote:
> On Wed, 2005-12-21 at 12:39 -0500, James Smart wrote:
>> Agreed.
>
> Is this critical for 2.6.15 or can it wait until after 2.6.15 is
> released?
>
> James
>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2005-12-21 18:46 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-12-16 21:16 [PATCH] lpfc: Timer fix Mark Haverkamp
2005-12-21 17:39 ` James Smart
2005-12-21 18:25 ` James Bottomley
2005-12-21 18:45 ` James Smart
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox