Re: [PATCH 5/6] scsi: libsas: factor out sas_ata_add_dev()

John Garry
2022-12-05T09:25:25Z

On 04/12/2022 08:16, Jason Yan wrote:
> +static inline int sas_ata_add_dev(struct domain_device *parent, struct ex_phy *phy,
> + struct domain_device *child, int phy_id)
> +{
> + pr_notice("ATA is not enabled, target proto 0x%x at %016llx:0x%x\n",

nit: how about add "SCSI_SAS_ATA is not enabled ..." or use similar to
the log in sas_discover_domain()?

> + phy->attached_tproto, SAS_ADDR(parent->sas_addr), phy_id);
> + return -ENODEV;