* [PATCH 2/10] iscsi: data under/over flow fix
@ 2006-01-13 5:08 Mike Christie
2006-01-13 18:12 ` Christoph Hellwig
0 siblings, 1 reply; 2+ messages in thread
From: Mike Christie @ 2006-01-13 5:08 UTC (permalink / raw)
To: linux-scsi
>From zhenyu.z.wang@intel.com:
We need to check the ISCSI_FLAG_DATA_* flags.
Signed-off-by: Alex Aizman <itn780@yahoo.com>
Signed-off-by: Dmitry Yusupov <dmitry_yus@yahoo.com>
Signed-off-by: Mike Christie <michaelc@cs.wisc.edu>
diff --git a/drivers/scsi/iscsi_tcp.c b/drivers/scsi/iscsi_tcp.c
index 49d6dd5..550ff66 100644
--- a/drivers/scsi/iscsi_tcp.c
+++ b/drivers/scsi/iscsi_tcp.c
@@ -357,7 +357,7 @@ iscsi_data_rsp(struct iscsi_conn *conn,
struct scsi_cmnd *sc = ctask->sc;
conn->exp_statsn = be32_to_cpu(rhdr->statsn) + 1;
- if (rhdr->flags & ISCSI_FLAG_CMD_UNDERFLOW) {
+ if (rhdr->flags & ISCSI_FLAG_DATA_UNDERFLOW) {
int res_count = be32_to_cpu(rhdr->residual_count);
if (res_count > 0 &&
@@ -367,9 +367,7 @@ iscsi_data_rsp(struct iscsi_conn *conn,
} else
sc->result = (DID_BAD_TARGET << 16) |
rhdr->cmd_status;
- } else if (rhdr->flags & ISCSI_FLAG_CMD_BIDI_UNDERFLOW)
- sc->result = (DID_BAD_TARGET << 16) | rhdr->cmd_status;
- else if (rhdr->flags & ISCSI_FLAG_CMD_OVERFLOW) {
+ } else if (rhdr->flags & ISCSI_FLAG_DATA_OVERFLOW) {
sc->resid = be32_to_cpu(rhdr->residual_count);
sc->result = (DID_OK << 16) | rhdr->cmd_status;
} else
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 2/10] iscsi: data under/over flow fix
2006-01-13 5:08 [PATCH 2/10] iscsi: data under/over flow fix Mike Christie
@ 2006-01-13 18:12 ` Christoph Hellwig
0 siblings, 0 replies; 2+ messages in thread
From: Christoph Hellwig @ 2006-01-13 18:12 UTC (permalink / raw)
To: Mike Christie; +Cc: linux-scsi
On Thu, Jan 12, 2006 at 11:08:27PM -0600, Mike Christie wrote:
> >From zhenyu.z.wang@intel.com:
>
> We need to check the ISCSI_FLAG_DATA_* flags.
ok
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-01-13 18:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-01-13 5:08 [PATCH 2/10] iscsi: data under/over flow fix Mike Christie
2006-01-13 18:12 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).