public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Mike Christie <michaelc@cs.wisc.edu>
To: Jens Axboe <axboe@suse.de>, linux-scsi@vger.kernel.org
Subject: [PATCH 2/6] scsi tgt: kill length alignment test in bin_map_user
Date: Thu, 16 Feb 2006 13:53:37 -0600	[thread overview]
Message-ID: <1140119617.20193.49.camel@max> (raw)

Subject: [PATCH] block layer: kill length alignment test in bin_map_user

The tgt project is mapping in bios using bio_map_user. The current targets
do not need their len to be aligned with a queue limit so this check is
causing some problems. Note: pointers passed into the kernel are properly
aligned by usersapace tgt code so the uaddr check in bio_map_user is ok.


The major user, blk_bio_map_user checks for the len before mapping
so it is not affected by this patch.

And the semi-newly added user blk_rq_map_user_iov has been failing
out when the len is not aligned properly so maybe people have been
good and not sending misaligned lens or that path is not used very
often and this change will not be very dangerous. st and sg do not
check the length and we have not seen any problem reports from those
wider used paths so this patch should be fairly safe - for mm 
and wider testing at least.


Signed-off-by: Mike Christie <michaelc@cs.wisc.edu>
Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>

---

 fs/bio.c |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)

8e515bd33c31c8dc5e9727792d2c3cbe08bc28e1
diff --git a/fs/bio.c b/fs/bio.c
index 1f3bb50..d8259d9 100644
--- a/fs/bio.c
+++ b/fs/bio.c
@@ -620,10 +620,9 @@ static struct bio *__bio_map_user_iov(re
 
 		nr_pages += end - start;
 		/*
-		 * transfer and buffer must be aligned to at least hardsector
-		 * size for now, in the future we can relax this restriction
+		 * buffer must be aligned to at least hardsector size for now
 		 */
-		if ((uaddr & queue_dma_alignment(q)) || (len & queue_dma_alignment(q)))
+		if (uaddr & queue_dma_alignment(q))
 			return ERR_PTR(-EINVAL);
 	}
 
-- 
1.1.3



             reply	other threads:[~2006-02-16 19:54 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-02-16 19:53 Mike Christie [this message]
2006-02-16 20:00 ` [PATCH 2/6] scsi tgt: kill length alignment test in bin_map_user Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1140119617.20193.49.camel@max \
    --to=michaelc@cs.wisc.edu \
    --cc=axboe@suse.de \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox