Linux SCSI subsystem development
 help / color / mirror / Atom feed
From: Willem Riede <osst@riede.org>
Cc: Christoph Hellwig <hch@infradead.org>,
	Christoph Hellwig <hch@lst.de>,
	linux-scsi@vger.kernel.org, James.Bottomley@steeleye.com,
	Andrew Morton <akpm@osdl.org>
Subject: Re: osst changes required to move forward to block request
Date: Sun, 19 Feb 2006 15:27:44 -0500	[thread overview]
Message-ID: <1140380864l.23688l.6l@athena.riede.org> (raw)
In-Reply-To: <20060214192447.GA20864@lst.de> (from hch@lst.de on Tue Feb 14 14:24:47 2006)

On 02/14/2006 02:24:47 PM, Christoph Hellwig wrote:
> 
> Looks good.  I didn't think about keeping the reuse and dealing with it
> in osst_do_scsi, but this obviously works.  Please tell if you're
> confident enough with it so we can put it in the for-2.6.17 tree.
> 
> Long-term we should probably get rid of the request reuse anyway,
> because it's not nessecary anymore and would make the code more
> readable.

I agree that would make the code easier to understand, but it will be a  
significant impact on the logic of the driver, whereas the current patch is  
relatively low impact. Which is exactly the reason why, yes, I do feel the  
change can at least be put in the -mm series and then migrate if we don't get  
any problem reports.

Thanks, Willem Riede.

  reply	other threads:[~2006-02-19 20:27 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-02-06 13:19 osst changes required to move forward to block request Christoph Hellwig
2006-02-07  1:02 ` Willem Riede
2006-02-07  9:12   ` Christoph Hellwig
2006-02-11 19:46     ` Willem Riede
2006-02-14 19:24       ` Christoph Hellwig
2006-02-19 20:27         ` Willem Riede [this message]
2006-03-07 11:59       ` Christoph Hellwig
2006-03-07 21:53         ` James Bottomley
2006-03-07 22:16           ` Willem Riede
2006-03-07 22:43           ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1140380864l.23688l.6l@athena.riede.org \
    --to=osst@riede.org \
    --cc=James.Bottomley@steeleye.com \
    --cc=akpm@osdl.org \
    --cc=hch@infradead.org \
    --cc=hch@lst.de \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox