public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: James Bottomley <James.Bottomley@SteelEye.com>
To: Mike Anderson <andmike@us.ibm.com>
Cc: linux-scsi <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH] fix scsi process problems and clean up the target reap issues
Date: Tue, 28 Feb 2006 11:39:04 -0600	[thread overview]
Message-ID: <1141148345.3258.24.camel@mulgrave.il.steeleye.com> (raw)
In-Reply-To: <20060228172436.GA1456@us.ibm.com>

On Tue, 2006-02-28 at 09:24 -0800, Mike Anderson wrote:
> The patch was tried on the aic7xxx ahc_linux_target_alloc issue I
> previously mentioned and it did not change the result of a BUG_ON.

Hmm ... could you repost the panic ... I also put in Brian King's check
for device_add failure, which should have picked this up ... it sounds
like there's something else going on.

> Is there some reason we cannot do the list_del_init(&starget->siblings) in
> scsi_target_dev_release post calling target_destroy? It would appear with
> the check for STARGET_DEL that being on the list longer should not be a
> problem.

No, it shouldn't ... it just potentially delays the allocation to wait
for everything to finish using the old target ... we might have to put a
reschedule in the retry loop in alloc to avoid a busy wait.

Does that fix your aic problem?

James



  reply	other threads:[~2006-02-28 17:39 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-02-23 20:27 [PATCH] fix scsi process problems and clean up the target reap issues James Bottomley
2006-02-28 17:24 ` Mike Anderson
2006-02-28 17:39   ` James Bottomley [this message]
2006-02-28 19:17     ` Mike Anderson
2006-02-28 19:52       ` James Bottomley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1141148345.3258.24.camel@mulgrave.il.steeleye.com \
    --to=james.bottomley@steeleye.com \
    --cc=andmike@us.ibm.com \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox