* [PATCH 5/6] lpfc 8.1.4 : Two misc fixes
@ 2006-03-07 20:04 James Smart
0 siblings, 0 replies; only message in thread
From: James Smart @ 2006-03-07 20:04 UTC (permalink / raw)
To: linux-scsi
Two misc fixes:
- Fix deadlock caused by return with host_lock held in lpfc_findnode_did
- Initialize all fields of the allocated mail box structure to zero.
Was causing some sysfs mailbox commands to fail immediately after load.
Signed-off-by: James Smart <James.Smart@emulex.com>
--- a/drivers/scsi/lpfc/lpfc_hbadisc.c
+++ b/drivers/scsi/lpfc/lpfc_hbadisc.c
@@ -1760,6 +1760,7 @@ lpfc_findnode_did(struct lpfc_hba * phba
phba->brd_no,
ndlp, ndlp->nlp_DID,
ndlp->nlp_flag, data1);
+ spin_unlock_irq(phba->host->host_lock);
return ndlp;
}
}
@@ -1805,6 +1806,7 @@ lpfc_findnode_did(struct lpfc_hba * phba
phba->brd_no,
ndlp, ndlp->nlp_DID,
ndlp->nlp_flag, data1);
+ spin_unlock_irq(phba->host->host_lock);
return ndlp;
}
}
--- a/drivers/scsi/lpfc/lpfc_attr.c
+++ b/drivers/scsi/lpfc/lpfc_attr.c
@@ -856,7 +856,7 @@ sysfs_mbox_write(struct kobject *kobj, c
mbox = mempool_alloc(phba->mbox_mem_pool, GFP_KERNEL);
if (!mbox)
return -ENOMEM;
-
+ memset(mbox, 0, sizeof (LPFC_MBOXQ_t));
}
spin_lock_irq(host->host_lock);
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2006-03-07 20:04 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-03-07 20:04 [PATCH 5/6] lpfc 8.1.4 : Two misc fixes James Smart
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).