From: Arjan van de Ven <arjan@infradead.org>
To: Rolf Eike Beer <eike-kernel@sf-tec.de>
Cc: Denis Vlasenko <vda@ilport.com.ua>,
SCSI List <linux-scsi@vger.kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] deinline some functions in aic7xxx drivers, save 80k of text
Date: Mon, 10 Apr 2006 18:20:40 +0200 [thread overview]
Message-ID: <1144686041.2876.2.camel@laptopd505.fenrus.org> (raw)
In-Reply-To: <200604100919.23244.eike-kernel@sf-tec.de>
On Mon, 2006-04-10 at 09:19 +0200, Rolf Eike Beer wrote:
> [Full quote and readded CC adresses. My fault, pressed wrong button]
>
> Denis Vlasenko wrote:
> > On Monday 10 April 2006 10:03, Rolf Eike Beer wrote:
> > > Am Montag, 10. April 2006 07:49 schrieben Sie:
> > > > On Monday 10 April 2006 08:44, Denis Vlasenko wrote:
> > > > > I also spotted two bugs in the process, patches
> > > > > for those will follow.
> > > >
> > > > ahd_delay(usec) is buggy. Just think how would it work
> > > > with usec == 1024*100 + 1...
> > >
> > > This is unneeded. The biggest argument this function is ever called with
> > > is 1000.
> >
> > I know.
> >
> > > I would suggest to delete this function completely. If one ever has to
> > > wait for a longer period mdelay() is the right function to call.
> >
> > I am leaving it up to maintainer to decide. After all, the driver
> > is for multiple OSes, other OS may lack mdelay().
actually this driver isn't shared anymore with other oses so it's ok to
remove (buggy) abstractions
next prev parent reply other threads:[~2006-04-10 23:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-10 5:44 [PATCH] deinline some functions in aic7xxx drivers, save 80k of text Denis Vlasenko
2006-04-10 5:46 ` Denis Vlasenko
2006-04-10 5:49 ` Denis Vlasenko
[not found] ` <200604100903.35431.eike-kernel@sf-tec.de>
[not found] ` <200604101015.36869.vda@ilport.com.ua>
2006-04-10 7:19 ` Rolf Eike Beer
2006-04-10 7:54 ` Denis Vlasenko
2006-04-10 9:40 ` Stefan Richter
2006-04-10 10:00 ` Hannes Reinecke
2006-04-10 10:16 ` Stefan Richter
2006-04-10 16:20 ` Arjan van de Ven [this message]
2006-04-10 8:43 ` Stefan Richter
2006-04-10 8:56 ` Denis Vlasenko
2006-04-10 10:19 ` Stefan Richter
2006-04-10 14:22 ` Justin T. Gibbs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1144686041.2876.2.camel@laptopd505.fenrus.org \
--to=arjan@infradead.org \
--cc=eike-kernel@sf-tec.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=vda@ilport.com.ua \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox