From mboxrd@z Thu Jan 1 00:00:00 1970 From: James Smart Subject: [REPOST][PATCH] update max sdev block limit Date: Thu, 11 May 2006 10:42:42 -0400 Message-ID: <1147358563.3507.4.camel@localhost.localdomain> Reply-To: James.Smart@Emulex.Com Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Return-path: Received: from emulex.emulex.com ([138.239.112.1]:4287 "EHLO emulex.emulex.com") by vger.kernel.org with ESMTP id S1751801AbWEKOmV (ORCPT ); Thu, 11 May 2006 10:42:21 -0400 Received: from xbl3.ad.emulex.com (xbl3.ma.emulex.com [138.239.73.12]) by emulex.emulex.com (8.13.6/8.13.6) with ESMTP id k4BEgK74012299 for ; Thu, 11 May 2006 07:42:20 -0700 (PDT) Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: linux-scsi@vger.kernel.org Updated patch to address comments from Andreas Herrman, who noted that the initialization, with the HZ, was inconsistent with its use in the FC transport. -- This patch ups the maximum limit for how long an sdev is allowed to be blocked. Originally, the value was 60 seconds. However, we are aware of array failover and switch reboot times that can be as high as 90 seconds. We're proposing to change the max to 120 seconds. -- james s Signed-off-by: James Smart diff -upNr a/drivers/scsi/scsi_priv.h b/drivers/scsi/scsi_priv.h --- a/drivers/scsi/scsi_priv.h 2006-05-10 11:36:25.000000000 -0400 +++ b/drivers/scsi/scsi_priv.h 2006-05-11 10:37:57.000000000 -0400 @@ -127,7 +127,7 @@ extern struct bus_type scsi_bus_type; * classes. */ -#define SCSI_DEVICE_BLOCK_MAX_TIMEOUT (HZ*60) +#define SCSI_DEVICE_BLOCK_MAX_TIMEOUT 120 /* units in seconds */ extern int scsi_internal_device_block(struct scsi_device *sdev); extern int scsi_internal_device_unblock(struct scsi_device *sdev);