Re: [REPOST][PATCH] update max sdev block limit

Patrick Mansfield
2006-05-16T16:35:06Z

On Tue, May 16, 2006 at 12:05:19PM -0400, James Smart wrote:
> I don't mind making it bigger, especially as this is just a max, not the
> default value. I tried to keep it low, as I believe even 2 mins is a long
> time from the system's perspective. 10 minutes is forever (and remember
> the scan deadlock that we just worked through).

Yes, so add default and max settings instead of using the max as the default.

And I still don't see how the scsi timeout can (reliably) make it through
these block/unblocks. EH_RESET_TIMER doesn't freeze the scsi timeout like
you really need, just restarts it.

For example, with default sd timeout of 30, you could be one second into a
command, block for 28 seconds, unblock, and then still timeout.

-- Patrick Mansfield