From: Amit Arora <aarora@in.ibm.com>
To: linux-scsi@vger.kernel.org
Cc: patmans@us.ibm.com
Subject: [PATCH] scsi: Return -EINVAL when "id == max_id" in scsi_scan_host_selected()
Date: Fri, 19 May 2006 16:14:50 -0700 [thread overview]
Message-ID: <1148080489.23417.18.camel@amitarora.in.ibm.com> (raw)
The scsi_scan_host_selected() should return -EINVAL when the id is equal
to the max_id. Currently it uses ">" when comparing with max_id, and
hence leaves the border case when "id==max_id".
The channel and lun have values valid from 0 up to,
and including, max_channel or max_lun. But, the valid values for id
range from 0 to max_id-1. This patch fixes the problem.
Regards,
Amit Arora
Signed-off-by: Amit Arora <aarora@in.ibm.com>
---
diff -Nuarp linux-2.6.17-rc4.orig/drivers/scsi/scsi_scan.c
linux-2.6.17-rc4/drivers/scsi/scsi_scan.c
--- linux-2.6.17-rc4.orig/drivers/scsi/scsi_scan.c 2006-05-18
20:25:32.000000000 -0600
+++ linux-2.6.17-rc4/drivers/scsi/scsi_scan.c 2006-05-18
20:28:09.000000000 -0600
@@ -1473,7 +1473,7 @@ int scsi_scan_host_selected(struct Scsi_
__FUNCTION__, channel, id, lun));
if (((channel != SCAN_WILD_CARD) && (channel >
shost->max_channel)) ||
- ((id != SCAN_WILD_CARD) && (id > shost->max_id)) ||
+ ((id != SCAN_WILD_CARD) && (id >= shost->max_id)) ||
((lun != SCAN_WILD_CARD) && (lun > shost->max_lun)))
return -EINVAL;
next reply other threads:[~2006-05-19 23:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-19 23:14 Amit Arora [this message]
2006-05-20 4:21 ` [PATCH] scsi: Return -EINVAL when "id == max_id" in scsi_scan_host_selected() Matthew Wilcox
2006-05-20 19:41 ` Amit Arora
2006-05-21 3:34 ` Luben Tuikov
2006-05-21 4:05 ` Matthew Wilcox
2006-05-22 19:01 ` Amit Arora
2006-05-23 0:54 ` James Bottomley
2006-05-23 1:16 ` Matthew Wilcox
2006-05-23 7:47 ` Hannes Reinecke
2006-05-23 8:29 ` Hannes Reinecke
2006-05-26 23:50 ` Luben Tuikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1148080489.23417.18.camel@amitarora.in.ibm.com \
--to=aarora@in.ibm.com \
--cc=linux-scsi@vger.kernel.org \
--cc=patmans@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox