From: Daejun Park <daejun7.park@samsung.com>
To: Bart Van Assche <bvanassche@acm.org>
Cc: "Martin K . Petersen" <martin.petersen@oracle.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
Jaegeuk Kim <jaegeuk@kernel.org>,
Avri Altman <avri.altman@wdc.com>, Bean Huo <beanhuo@micron.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Stanley Chu <stanley.chu@mediatek.com>,
Can Guo <cang@codeaurora.org>,
Asutosh Das <asutoshd@codeaurora.org>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Daejun Park <daejun7.park@samsung.com>
Subject: RE: [PATCH v3 05/18] scsi: ufs: Use DECLARE_COMPLETION_ONSTACK() where appropriate
Date: Thu, 29 Jul 2021 09:57:07 +0900 [thread overview]
Message-ID: <1150284200.161627520284458.JavaMail.epsvc@epcpadp4> (raw)
In-Reply-To: <20210722033439.26550-6-bvanassche@acm.org>
Hi Bart,
>From Documentation/scheduler/completion.rst: "When a completion is declared
>as a local variable within a function, then the initialization should
>always use DECLARE_COMPLETION_ONSTACK() explicitly, not just to make
>lockdep happy, but also to make it clear that limited scope had been
>considered and is intentional."
Reviewed-by: Daejun Park <daejun7.park@samsung.com>
Thanks,
Daejun
next prev parent reply other threads:[~2021-07-29 0:58 UTC|newest]
Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-22 3:34 [PATCH v3 00/18] UFS patches for kernel v5.15 Bart Van Assche
2021-07-22 3:34 ` [PATCH v3 01/18] scsi: ufs: Fix memory corruption by ufshcd_read_desc_param() Bart Van Assche
2021-07-25 12:40 ` Avri Altman
2021-07-29 0:56 ` Daejun Park
2021-07-22 3:34 ` [PATCH v3 02/18] scsi: ufs: Reduce power management code duplication Bart Van Assche
2021-07-29 0:56 ` Daejun Park
2021-07-31 14:44 ` Stanley Chu
2021-07-22 3:34 ` [PATCH v3 03/18] scsi: ufs: Only include power management code if necessary Bart Van Assche
2021-07-29 0:56 ` Daejun Park
2021-07-31 14:48 ` Stanley Chu
2021-07-22 3:34 ` [PATCH v3 04/18] scsi: ufs: Rename the second ufshcd_probe_hba() argument Bart Van Assche
2021-07-29 0:56 ` Daejun Park
2021-08-02 8:17 ` Stanley Chu
2021-07-22 3:34 ` [PATCH v3 05/18] scsi: ufs: Use DECLARE_COMPLETION_ONSTACK() where appropriate Bart Van Assche
2021-07-29 0:57 ` Daejun Park [this message]
2021-07-22 3:34 ` [PATCH v3 06/18] scsi: ufs: Remove ufshcd_valid_tag() Bart Van Assche
2021-07-28 6:48 ` Daejun Park
2021-07-28 22:48 ` Bart Van Assche
2021-07-29 0:26 ` Daejun Park
2021-07-22 3:34 ` [PATCH v3 07/18] scsi: ufs: Verify UIC locking requirements at runtime Bart Van Assche
2021-07-29 0:57 ` Daejun Park
2021-07-22 3:34 ` [PATCH v3 08/18] scsi: ufs: Improve static type checking for the host controller state Bart Van Assche
2021-07-28 7:56 ` Keoseong Park
2021-07-29 0:57 ` Daejun Park
2021-07-22 3:34 ` [PATCH v3 09/18] scsi: ufs: Remove several wmb() calls Bart Van Assche
2021-07-25 13:20 ` Avri Altman
2021-07-29 1:24 ` Daejun Park
2021-07-22 3:34 ` [PATCH v3 10/18] scsi: ufs: Inline ufshcd_outstanding_req_clear() Bart Van Assche
2021-07-29 7:42 ` Bean Huo
2021-07-22 3:34 ` [PATCH v3 11/18] scsi: ufs: Revert "Utilize Transfer Request List Completion Notification Register" Bart Van Assche
2021-07-29 8:03 ` Bean Huo
2021-07-29 16:10 ` Bart Van Assche
2021-07-29 16:13 ` Bart Van Assche
2021-07-29 21:14 ` Bean Huo
2021-08-02 15:24 ` Bean Huo
2021-08-03 18:49 ` Bart Van Assche
2021-07-22 3:34 ` [PATCH v3 12/18] scsi: ufs: Optimize serialization of setup_xfer_req() calls Bart Van Assche
2021-07-29 1:25 ` Daejun Park
2021-07-29 8:07 ` Bean Huo
2021-07-22 3:34 ` [PATCH v3 13/18] scsi: ufs: Optimize SCSI command processing Bart Van Assche
2021-07-29 1:25 ` Daejun Park
2021-07-29 9:12 ` Bean Huo
2021-07-29 16:11 ` Bart Van Assche
2021-08-02 12:11 ` Bean Huo
2021-07-22 3:34 ` [PATCH v3 14/18] scsi: ufs: Fix the SCSI abort handler Bart Van Assche
2021-08-02 13:15 ` Bean Huo
2021-07-22 3:34 ` [PATCH v3 15/18] scsi: ufs: Request sense data asynchronously Bart Van Assche
2021-08-02 13:16 ` Bean Huo
2021-07-22 3:34 ` [PATCH v3 16/18] scsi: ufs: Synchronize SCSI and UFS error handling Bart Van Assche
2021-08-02 14:24 ` Bean Huo
2021-08-28 9:47 ` Adrian Hunter
2021-08-29 7:17 ` Avri Altman
2021-08-29 21:33 ` Bart Van Assche
2021-08-29 9:57 ` Adrian Hunter
2021-08-29 22:18 ` Bart Van Assche
2021-08-31 7:24 ` Adrian Hunter
2021-08-31 10:04 ` Adrian Hunter
2021-08-31 17:18 ` Bart Van Assche
2021-09-01 7:42 ` Adrian Hunter
2021-09-01 20:46 ` Bart Van Assche
2021-09-02 6:02 ` Adrian Hunter
2021-07-22 3:34 ` [PATCH v3 17/18] scsi: ufs: Retry aborted SCSI commands instead of completing these successfully Bart Van Assche
2021-08-02 15:03 ` Bean Huo
2021-07-22 3:34 ` [PATCH v3 18/18] scsi: ufs: Add fault injection support Bart Van Assche
2021-08-02 15:03 ` Bean Huo
2021-08-03 2:13 ` [PATCH v3 00/18] UFS patches for kernel v5.15 Martin K. Petersen
2021-08-10 5:20 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1150284200.161627520284458.JavaMail.epsvc@epcpadp4 \
--to=daejun7.park@samsung.com \
--cc=adrian.hunter@intel.com \
--cc=asutoshd@codeaurora.org \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=cang@codeaurora.org \
--cc=jaegeuk@kernel.org \
--cc=jejb@linux.ibm.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=matthias.bgg@gmail.com \
--cc=stanley.chu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox