From: James Bottomley <James.Bottomley@SteelEye.com>
To: "Moore, Eric" <Eric.Moore@lsil.com>
Cc: linux-scsi <linux-scsi@vger.kernel.org>
Subject: RE: [PATCH] scsi_transport_sas: introduce a sas_port entity
Date: Tue, 20 Jun 2006 16:43:48 -0500 [thread overview]
Message-ID: <1150839828.2531.31.camel@mulgrave.il.steeleye.com> (raw)
In-Reply-To: <664A4EBB07F29743873A87CF62C26D7019A05F@NAMAIL4.ad.lsil.com>
On Tue, 2006-06-20 at 13:11 -0600, Moore, Eric wrote:
> Stack traceback for pid 7313
> 0xffff81001e111040 7313 7300 1 1 R 0xffff81001e111370
> *insmod
> RSP RIP Function (args)
> 0xffff810006e61b60 0xffffffff802645cc
> attribute_container_device_trigger+0x49 (0xffff81000e06c488,
> 0xffff81000927b8c0, 0xffff81000e06c4e0)
> 0xffff810006e61b78 0xffffffff802645cf
> attribute_container_device_trigger+0x4c (0xffff8100041c11d8,
> 0xffff8100041c11d8, 0xffff8100041c1000, 0x0, 0xffff8100041c11d8)
> 0xffff810006e61b98 0xffffffff802643a0
> attribute_container_add_device+0x57 (0xffffffffffffffff,
> 0xffffffffffffffff, 0xffff81001e4f1090, 0xffff81001e4f0ed0,
Oh, this one's actually quite simple: the phys aren't being deleted from
the expander. Try this fix:
James
diff --git a/drivers/scsi/scsi_transport_sas.c b/drivers/scsi/scsi_transport_sas.c
index 2a5899d..e79d6d3 100644
--- a/drivers/scsi/scsi_transport_sas.c
+++ b/drivers/scsi/scsi_transport_sas.c
@@ -1176,7 +1176,7 @@ sas_rphy_delete(struct sas_rphy *rphy)
break;
case SAS_EDGE_EXPANDER_DEVICE:
case SAS_FANOUT_EXPANDER_DEVICE:
- device_for_each_child(dev, NULL, do_sas_phy_delete);
+ sas_remove_children(dev);
break;
default:
break;
next prev parent reply other threads:[~2006-06-20 21:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-20 19:11 [PATCH] scsi_transport_sas: introduce a sas_port entity Moore, Eric
2006-06-20 21:43 ` James Bottomley [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-06-20 22:09 Moore, Eric
2006-06-20 17:37 Moore, Eric
2006-06-20 17:45 ` James Bottomley
2006-06-17 0:16 Moore, Eric
2006-06-17 19:06 ` James Bottomley
2006-05-31 23:25 Moore, Eric
2006-06-12 14:18 ` James Bottomley
2006-05-31 17:10 Moore, Eric
2006-05-31 17:22 ` James Bottomley
2006-05-31 4:04 James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1150839828.2531.31.camel@mulgrave.il.steeleye.com \
--to=james.bottomley@steeleye.com \
--cc=Eric.Moore@lsil.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox