RE: [PATCH] mptsas: eliminate ghost devices

Moore, Eric
2006-06-30T22:38:25Z

On Friday, June 30, 2006 3:25 PM, James Bottomley wrote:
>
> On Fri, 2006-06-30 at 15:07 -0600, Eric Moore wrote:
> > + if (scsi_is_host_device(parent)) {
> > + if (!identify.target_port_protocols &&
> > + (identify.device_type ==
> > SAS_END_DEVICE))
> > + goto out;
>
> Won't this happen for any initiator, rather than just the parent (i.e.
> in a multi-initiator environment we won't see anything even for remote
> initiators)?
>

I believe my code is correct. The scsi_is_host_device(parent) condition
will only be entered from an expander one level down from the host hba,
and this case
will remove for all rphys that would of been reported pointing back to
the
host hba. So in the case you have two initiators connected to the same
expander,
I think it would be expected that all ghost rphys need not be reported
for all host
host hba's connected to the same expander, right?

If the remote initiator is located beyond the 1st leve expander, or
direct
connected to each other, this condition will not entered.

Eric