RE: [PATCH] mptsas: eliminate ghost devices

James Bottomley
2006-06-30T22:59:41Z

On Fri, 2006-06-30 at 16:38 -0600, Moore, Eric wrote:
> I believe my code is correct. The scsi_is_host_device(parent) condition
> will only be entered from an expander one level down from the host hba,
> and this case
> will remove for all rphys that would of been reported pointing back to
> the
> host hba. So in the case you have two initiators connected to the same
> expander,
> I think it would be expected that all ghost rphys need not be reported
> for all host
> host hba's connected to the same expander, right?

Yes, but we want an end device for a remote HBA, which your condition
would also eliminate. It shows useful information (like sas address and
parameters).

> If the remote initiator is located beyond the 1st leve expander, or
> direct
> connected to each other, this condition will not entered.

Right ... here we'll see the end device, so if we go with your patch
we'd see an end device for a remote HBA connected to a second level
expander but not for a first level one. Whatever happens, we need to be
consistent ...

James