public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: James Bottomley <James.Bottomley@SteelEye.com>
To: "Moore, Eric" <Eric.Moore@lsil.com>
Cc: linux-scsi@vger.kernel.org
Subject: RE: [PATCH] mptsas: eliminate ghost devices
Date: Fri, 30 Jun 2006 17:59:27 -0500	[thread overview]
Message-ID: <1151708367.8921.60.camel@mulgrave.il.steeleye.com> (raw)
In-Reply-To: <664A4EBB07F29743873A87CF62C26D701BE45B@NAMAIL4.ad.lsil.com>

On Fri, 2006-06-30 at 16:38 -0600, Moore, Eric wrote:
> I believe my code is correct.  The scsi_is_host_device(parent) condition
> will only be entered from an expander one level down from the host hba,
> and this case
> will remove for all rphys that would of been reported pointing back to
> the 
> host hba.  So in the case you have two initiators connected to the same
> expander,
> I think it would be expected that all ghost rphys need not be reported
> for all host
> host hba's connected to the same expander, right?  

Yes, but we want an end device for a remote HBA, which your condition
would also eliminate.  It shows useful information (like sas address and
parameters).

> If the remote initiator is located beyond the 1st leve expander, or
> direct
> connected to each other, this condition will not entered.

Right ... here we'll see the end device, so if we go with your patch
we'd see an end device for a remote HBA connected to a second level
expander but not for a first level one.  Whatever happens, we need to be
consistent ...

James


  reply	other threads:[~2006-06-30 22:59 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-30 22:38 [PATCH] mptsas: eliminate ghost devices Moore, Eric
2006-06-30 22:59 ` James Bottomley [this message]
  -- strict thread matches above, loose matches on Subject: below --
2006-06-30 23:28 Moore, Eric
2006-06-30 21:07 Eric Moore
2006-06-30 21:25 ` James Bottomley
2006-06-30 17:54 James Bottomley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1151708367.8921.60.camel@mulgrave.il.steeleye.com \
    --to=james.bottomley@steeleye.com \
    --cc=Eric.Moore@lsil.com \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox