Re: aic94xx status

Mike Anderson
2006-07-10T16:09:14Z

James Bottomley <James.Bottomley@SteelEye.com> wrote:
> 1) SATA support. We at least need this stubbed out so seeing a SATA
> device won't cause nasty things to happen (IBM is working on this).
> Ideally, we need to integrate this driver with Brian King's SATA/SAS
> code, but no-one who has this board has a sata device and vice versa.
>

Currently I am running a loaned SATA drive with the patch below. It just
generates the "Unidentified device type" type message when it detects a
SATA device and appears in my configuration to not cause any bad things to
happen.

-andmike
--
Michael Anderson
andmike@us.ibm.com

Do not drop phy_list_lock is we have not taken it. Also added a SATA_DEV
case as marker for future calls.

Signed-off-by: Mike Anderson <andmike@us.ibm.com>

drivers/scsi/sas/sas_discover.c | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)

Index: aic94xx-sas-2.6-patched/drivers/scsi/sas/sas_discover.c
===================================================================
--- aic94xx-sas-2.6-patched.orig/drivers/scsi/sas/sas_discover.c 2006-06-23 11:12:01.000000000 -0700
+++ aic94xx-sas-2.6-patched/drivers/scsi/sas/sas_discover.c 2006-07-05 13:19:20.000000000 -0700
@@ -265,6 +265,7 @@ static int sas_get_port_device(struct as
rphy = sas_expander_alloc(port->port,
SAS_FANOUT_EXPANDER_DEVICE);
break;
+ case SATA_DEV:
default:
printk("ERROR: Unidentified device type %d\n", dev->dev_type);
rphy = NULL;
@@ -272,7 +273,6 @@ static int sas_get_port_device(struct as
}

if (!rphy) {
- spin_unlock_irqrestore(&port->phy_list_lock, flags);
kfree(dev);
return -ENODEV;
}