From: James Bottomley <James.Bottomley@SteelEye.com>
To: Eric Moore <eric.moore@lsil.com>
Cc: linux-scsi@vger.kernel.org
Subject: Re: [PATCH] mptsas : reserving a channel for integrated raid
Date: Tue, 11 Jul 2006 15:11:22 -0400 [thread overview]
Message-ID: <1152645083.3575.67.camel@mulgrave.il.steeleye.com> (raw)
In-Reply-To: <20060711162543.GA11553@lsil.com>
On Tue, 2006-07-11 at 10:25 -0600, Eric Moore wrote:
> Recent changes in the sas transport layer have taken
> ownership of port_id(channel) assignments. Previously
> this was owned by the scsi lld, and mptsas code was written
> to reserve the channel beyond the last port id for integrated
> raid. With this change in the transport layer, any non-raid devices
> that land on the reserved channel will not be detected due to
> improper firmware h:c:t:l mapping calculation.
>
> This patch moves the reserved channel to -1. This can be
> easily changed to some other value in the future release
> since its a hash define.
I don't think -1 showing up in the channel field is a good idea ... I
bet it will confuse parsers of that information.
> Its higly doubtfull the transport layer would ever
> use up all the port ids, and wrap back around to zero since
> this is int.
Do we still need this channel number as port number stuff anyway?
Originally it was the outgoing phy that was identified in the channel,
but even that's no longer true. Since the target ids are assigned per
HBA, they're unique enough without requiring additional channel
stuff ... how about killing the non zero channel in the sas transport
class and then you can simply use 1 for the raid virtual channel?
James
next prev parent reply other threads:[~2006-07-11 19:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-11 16:25 [PATCH] mptsas : reserving a channel for integrated raid Eric Moore
2006-07-11 19:11 ` James Bottomley [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-07-11 21:42 Moore, Eric
2006-07-11 21:49 ` James Bottomley
2006-07-11 22:30 Moore, Eric
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1152645083.3575.67.camel@mulgrave.il.steeleye.com \
--to=james.bottomley@steeleye.com \
--cc=eric.moore@lsil.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox