Re: [PATCH] hptiop: backout ioctl mess

HighPoint Linux Team
2006-08-03T03:11:22Z

Arjan van de Ven wrote:
> > Christoph Hellwig wrote:
> > > The hptiop just got merged with a horrible amount of really bad ioctl
> > > code that is against the standards for new scsi drivers. This patch
> > > backs it out (and fixes a small bug where scsi_add_host is called to
> > > early). We can re-add proper APIs once we agree on them.
> >
> > What is the standard implemetation of private ioctls for scsi drivers?
> > Thanks.
>
> Hi,
>
> the real answer is: try really hard to use generic ioctls for your
> functionality. What exactly do you need private ioctls for?
> It's quite possible that there is a generic way to do the same thing
> already, or something that can easily be extended to do what you need...

We use private ioctls for RAID management. The driver registers a char
device for application to access the IOP. Several scsi drivers
(aacraid, 3w-9xxx, megaraid) use register_chrdev() for ioctls - is
this deprecated?

Another way is using scsi_host_template.ioctl interface but application
has no device node to open when there is no device on the controller.
Same problem on using sg_ioctl or scsi passthrough interface.

HighPoint Linux Team