From: David C Somayajulu <david.somayajulu@qlogic.com>
To: Mike Christie <michaelc@cs.wisc.edu>
Cc: Doug Maxey <dwm@enoyolf.org>, Ravi Anand <ravi.anand@qlogic.com>,
open-iscsi@googlegroups.com, linux-scsi@vger.kernel.org
Subject: Re: [PATCH 3/3] qla4xxx: iospace_config move defn
Date: Wed, 09 Aug 2006 12:23:04 -0700 [thread overview]
Message-ID: <1155151384.3850.3.camel@dcslnxpc.site> (raw)
In-Reply-To: <44DA21BE.3050506@cs.wisc.edu>
On Wed, 2006-08-09 at 13:56 -0400, Mike Christie wrote:
> Doug Maxey wrote:
> > From: Doug Maxey <dwm@enoyolf.org>
> >
> > Move the defn before the caller, and remove the decl.
> >
>
> I think not doing the defn before the caller is nice, but I honestly
> could care less either way as far as merging things goes (it seems like
> Christoph hates then but people like Jeff let the driver writer do what
> they want). Qlogic seems to love doing it, so are they ok with all these
> patches?
We have no problem with these patches since it makes the code cleaner
and makes everyone happy.
-david S.
next prev parent reply other threads:[~2006-08-09 19:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-09 18:24 [PATCHSET] qla4xxx: more qla4xxx cleanup Doug Maxey
2006-08-09 18:42 ` [PATCH 1/3] qla4xxx: clarify doc for probe_adapter Doug Maxey
2006-08-09 18:42 ` [PATCH 2/3] qla4xxx: really move free_adapter Doug Maxey
2006-08-09 18:42 ` [PATCH 3/3] qla4xxx: iospace_config move defn Doug Maxey
2006-08-09 17:56 ` Mike Christie
2006-08-09 18:03 ` Mike Christie
2006-08-09 20:38 ` Doug Maxey
2006-08-09 19:23 ` David C Somayajulu [this message]
2006-08-09 20:15 ` Andrew Vasquez
2006-08-09 20:21 ` James Bottomley
2006-08-09 22:16 ` David C Somayajulu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1155151384.3850.3.camel@dcslnxpc.site \
--to=david.somayajulu@qlogic.com \
--cc=dwm@enoyolf.org \
--cc=linux-scsi@vger.kernel.org \
--cc=michaelc@cs.wisc.edu \
--cc=open-iscsi@googlegroups.com \
--cc=ravi.anand@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox