Re: [PATCH] block: add support for shared tag maps

Jens Axboe
2006-08-31T08:57:22Z

On Thu, Aug 31 2006, Ed Lin wrote:
>
> ======= On 2006-08-30 21:44:18, James Bottomley wrote:
> >+
> >+/**
> >+ * blk_free_tags - release a given set of tag maintenance info
> >+ *
> >+ * @bqt: the tag map to free
> >+ *
> >+ * For externally managed @bqt@ frees the map. Callers of this
> >+ * function must guarantee to have released all the queues that
> >+ * might have been using this tag map.
> >+ */
> >+void blk_free_tags(struct blk_queue_tag *bqt)
> >+{
> >+ if (unlikely(!__blk_free_tags(bqt)))
> >+ BUG();
> >+}
> >+
>
> EXPORT_SYMBOL(blk_free_tags) ?
> Also, add new function definitions in blkdev.h?

Good point. James will be reposting it anyways, the patch needed a few
more fixes (memory leak, coding style).

--
Jens Axboe