From: James Bottomley <James.Bottomley@SteelEye.com>
To: Henne <henne@nachtwindheim.de>
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/5] mvme147: Scsi_Cmnd to struct scsi_cmnd convertion
Date: Tue, 12 Sep 2006 15:23:33 -0500 [thread overview]
Message-ID: <1158092613.3461.43.camel@mulgrave.il.steeleye.com> (raw)
In-Reply-To: <4506FCEE.1070209@nachtwindheim.de>
On Tue, 2006-09-12 at 20:31 +0200, Henne wrote:
> Changes obsolete typedef'd Scsi_Cmnd to struct scsi_cmnd.
> Signed-off-by: Henrik Kretzschmar <henne@nachtwindheim.de>
Actually, just a single patch for all the coupled drivers would be
better, please.
> -int wd33c93_queuecommand(Scsi_Cmnd *, void (*done)(Scsi_Cmnd *));
> -int wd33c93_abort(Scsi_Cmnd *);
> -int wd33c93_reset(Scsi_Cmnd *, unsigned int);
> +int wd33c93_queuecommand(struct scsi_cmnd *, void (*done)(struct scsi_cmnd *));
> +int wd33c93_abort(struct scsi_cmnd *);
> +int wd33c93_reset(struct scsi_cmnd *, unsigned int);
These prototypes are all unnecessary and can be pulled out of the
individual header files. The first two are provided by wd33c93.h and
the last one isn't actually in the body of any file.
wd33c93_info is also unused and can go.
Thanks,
James
prev parent reply other threads:[~2006-09-12 20:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-12 18:31 [PATCH 4/5] mvme147: Scsi_Cmnd to struct scsi_cmnd convertion Henne
2006-09-12 20:23 ` James Bottomley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1158092613.3461.43.camel@mulgrave.il.steeleye.com \
--to=james.bottomley@steeleye.com \
--cc=henne@nachtwindheim.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox