From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Christoph Hellwig <hch@infradead.org>
Cc: James.Bottomley@HansenPartnership.com, linux-scsi@vger.kernel.org
Subject: Re: [PATCH] scsi: Switch some more scsi drivers to pci_get_device and refcounted pci structures
Date: Mon, 18 Sep 2006 20:45:44 +0100 [thread overview]
Message-ID: <1158608744.6069.162.camel@localhost.localdomain> (raw)
In-Reply-To: <20060918190155.GE17670@infradead.org>
Ar Llu, 2006-09-18 am 20:01 +0100, ysgrifennodd Christoph Hellwig:
> NACK. This doesn't help us forward at all. In case you have
> the hardware please do a full conversion to the real pci probing API.
Then please mark every SCSI user of pci_find_device() as && BROKEN and
delete them in 6 months because I want to remove pci_find_device because
its a hazard. The patch I proposed ensures the driver doesn't crash the
box iterating the list unsafely. If you won't accept safe iteration the
driver should be deleted.
I guess the other alternative would be to add !HOTPLUG to all the
offenders and remove pci_find_device if hotplug is enabled.
Be honest - nobody is ever going to convert that driver or the other
ancient scsi drivers or the serial drivers to the pci module API even if
you play political games NAKing other fixes to try and make it happen.
James - what would you prefer - removal, && BROKEN, && !HOTPLUG or at
least fixing one thing that needs a fix ?
Alan
next prev parent reply other threads:[~2006-09-18 19:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-15 14:34 [PATCH] scsi: Switch some more scsi drivers to pci_get_device and refcounted pci structures Alan Cox
2006-09-18 19:01 ` Christoph Hellwig
2006-09-18 19:45 ` Alan Cox [this message]
2006-09-19 2:10 ` Doug Ledford
2006-09-19 8:32 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1158608744.6069.162.camel@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=James.Bottomley@HansenPartnership.com \
--cc=hch@infradead.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox