From: Doug Ledford <dledford@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
James.Bottomley@HansenPartnership.com,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH] scsi: Switch some more scsi drivers to pci_get_device and refcounted pci structures
Date: Mon, 18 Sep 2006 22:10:20 -0400 [thread overview]
Message-ID: <1158631820.17671.99.camel@fc6.xsintricity.com> (raw)
In-Reply-To: <20060918190155.GE17670@infradead.org>
[-- Attachment #1: Type: text/plain, Size: 1271 bytes --]
On Mon, 2006-09-18 at 20:01 +0100, Christoph Hellwig wrote:
> On Fri, Sep 15, 2006 at 03:34:32PM +0100, Alan Cox wrote:
> > Signed-off-by: Alan Cox <alan@redhat.com>
> >
> > diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.18-rc6-mm1/drivers/scsi/aic7xxx_old.c linux-2.6.18-rc6-mm1/drivers/scsi/aic7xxx_old.c
> > --- linux.vanilla-2.6.18-rc6-mm1/drivers/scsi/aic7xxx_old.c 2006-09-11 17:00:17.000000000 +0100
> > +++ linux-2.6.18-rc6-mm1/drivers/scsi/aic7xxx_old.c 2006-09-14 16:50:25.000000000 +0100
> > @@ -9194,7 +9194,7 @@
> > for (i = 0; i < ARRAY_SIZE(aic_pdevs); i++)
> > {
> > pdev = NULL;
> > - while ((pdev = pci_find_device(aic_pdevs[i].vendor_id,
> > + while ((pdev = pci_get_device(aic_pdevs[i].vendor_id,
> > aic_pdevs[i].device_id,
>
> NACK. This doesn't help us forward at all. In case you have
> the hardware please do a full conversion to the real pci probing API.
OMG, does anyone still use that thing?
--
Doug Ledford <dledford@redhat.com>
GPG KeyID: CFBFF194
http://people.redhat.com/dledford
Infiniband specific RPMs available at
http://people.redhat.com/dledford/Infiniband
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2006-09-19 2:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-15 14:34 [PATCH] scsi: Switch some more scsi drivers to pci_get_device and refcounted pci structures Alan Cox
2006-09-18 19:01 ` Christoph Hellwig
2006-09-18 19:45 ` Alan Cox
2006-09-19 2:10 ` Doug Ledford [this message]
2006-09-19 8:32 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1158631820.17671.99.camel@fc6.xsintricity.com \
--to=dledford@redhat.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=hch@infradead.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox