public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: David C Somayajulu <david.somayajulu@qlogic.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: James Bottomley <James.Bottomley@SteelEye.com>,
	linux-scsi@vger.kernel.org, Mike Christie <michaelc@cs.wisc.edu>,
	Doug Maxey <dwm@enoyolf.org>,
	David Wagner <david.wagner@qlogic.com>
Subject: Re: [RFC] [PATCH] helper function for retrieving scsi_cmd given host based block layer tag
Date: Fri, 22 Sep 2006 10:09:57 -0700	[thread overview]
Message-ID: <1158944997.4040.10.camel@dcslnxpc.site> (raw)
In-Reply-To: <1158710201.4358.8.camel@dcslnxpc.site>

On Tue, 2006-09-19 at 16:56 -0700, David C Somayajulu wrote:
> This was necessitated by the need for a function to get back
> to a scsi_cmnd, when an hba the posts its (corresponding) completion 
> interrupt with a block layer tag as its reference.
Regenerated the patch with reference to
git://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-2.6-block.git
Also fixed tabs.

Here is the link to the same patch with reference scsi-misc just in case
( ftp://ftp.qlogic.com/outgoing/linux/iSCSI/upstream/5.00.05b10-k/blk_tag_helper_patch.txt  )

Signed-off-by: Mike Christie <michaelc@cs.wisc.edu>
Signed-off-by: David Somayajulu <david.somayajulu@qlogic.com>


---

 block/ll_rw_blk.c       |    7 +------
 include/linux/blkdev.h  |    8 ++++++++
 include/scsi/scsi_tcq.h |   20 ++++++++++++++++++++
 3 files changed, 29 insertions(+), 6 deletions(-)

f07bce89f5707f53a502543b47a95fea1b041084
diff --git a/block/ll_rw_blk.c b/block/ll_rw_blk.c
index ddd9253..6c55467 100644
--- a/block/ll_rw_blk.c
+++ b/block/ll_rw_blk.c
@@ -837,12 +837,7 @@ EXPORT_SYMBOL(blk_queue_dma_alignment);
  **/
 struct request *blk_queue_find_tag(request_queue_t *q, int tag)
 {
-	struct blk_queue_tag *bqt = q->queue_tags;
-
-	if (unlikely(bqt == NULL || tag >= bqt->real_max_depth))
-		return NULL;
-
-	return bqt->tag_index[tag];
+	return blk_map_queue_find_tag(q->queue_tags, tag);
 }
 
 EXPORT_SYMBOL(blk_queue_find_tag);
diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
index aafe827..924d05e 100644
--- a/include/linux/blkdev.h
+++ b/include/linux/blkdev.h
@@ -747,6 +747,14 @@ extern int blk_queue_resize_tags(request
 extern void blk_queue_invalidate_tags(request_queue_t *);
 extern long blk_congestion_wait(int rw, long timeout);
 
+static inline struct request *blk_map_queue_find_tag(struct blk_queue_tag *bqt, 
+						int tag)
+{
+	if (unlikely(bqt == NULL || tag >= bqt->real_max_depth))
+		return NULL;
+	return bqt->tag_index[tag];
+}
+
 extern void blk_rq_bio_prep(request_queue_t *, struct request *, struct bio *);
 extern int blkdev_issue_flush(struct block_device *, sector_t *);
 
diff --git a/include/scsi/scsi_tcq.h b/include/scsi/scsi_tcq.h
index e47e36a..1733b4d 100644
--- a/include/scsi/scsi_tcq.h
+++ b/include/scsi/scsi_tcq.h
@@ -131,4 +131,24 @@ static inline struct scsi_cmnd *scsi_fin
 	return sdev->current_cmnd;
 }
 
+/**
+ * scsi_host_find_tag - find the tagged command by host
+ * @shost: pointer to scsi_host
+ * @tag: tag of the scsi_cmnd
+ *
+ * Notes:
+ *	Only works with tags allocated by the generic blk layer.
+ **/
+static inline struct scsi_cmnd *scsi_host_find_tag(struct Scsi_Host *shost,
+						int tag)
+{
+	struct request *req;
+
+	if (tag != SCSI_NO_TAG) {
+		req = blk_map_queue_find_tag(shost->bqt, tag);
+		return req ? (struct scsi_cmnd *)req->special : NULL;
+	}
+	return NULL;
+}
+
 #endif /* _SCSI_SCSI_TCQ_H */
-- 




  reply	other threads:[~2006-09-22 17:09 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-19 23:56 RFC] [PATCH] helper function for retrieving scsi_cmd given host based block layer tag David C Somayajulu
2006-09-22 17:09 ` David C Somayajulu [this message]
2006-09-22 19:11   ` [RFC] " Jens Axboe
2006-09-22 22:00     ` David C Somayajulu
2006-10-03 18:06       ` David Somayajulu
2006-10-03 19:10         ` Jens Axboe
2006-10-03 20:43           ` David Somayajulu
2006-10-03 22:27           ` David C Somayajulu
2006-10-04  6:27             ` Jens Axboe
2006-10-04 16:27               ` David Somayajulu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1158944997.4040.10.camel@dcslnxpc.site \
    --to=david.somayajulu@qlogic.com \
    --cc=James.Bottomley@SteelEye.com \
    --cc=axboe@kernel.dk \
    --cc=david.wagner@qlogic.com \
    --cc=dwm@enoyolf.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=michaelc@cs.wisc.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox