Re: [RFC PATCH] move aic7xxx to pci_request_irq

Matthew Wilcox
2006-10-02T18:27:44Z

On Mon, Oct 02, 2006 at 08:07:03PM +0000, Frederik Deweerdt wrote:
> +++ b/drivers/scsi/aic7xxx/aic79xx_osm_pci.c
> @@ -341,12 +341,12 @@ ahd_pci_map_int(struct ahd_softc *ahd)
> {
> int error;
>
> - error = request_irq(ahd->dev_softc->irq, ahd_linux_isr,
> - IRQF_SHARED, "aic79xx", ahd);
> + error = pci_request_irq(ahd->dev_softc, ahd_linux_isr,
> + IRQF_SHARED, "aic79xx");
> if (!error)
> ahd->platform_data->irq = ahd->dev_softc->irq;
>
> - return (-error);
> + return error;

Seems unsafe to me. Unless you want to trace through the whole driver
changing its internal conventions to use negative errnos like the rest
of the kernel.

> -
> - return (-error);
> -}
>
> + return error;
> +}

Ditto.