Re: [PATCH] Introduce BROKEN_ON_64BIT facility

Andi Kleen
2006-10-02T09:52:14Z

Jeff Garzik <jeff@garzik.org> writes:

> Add a broken-on-64bit option, similar to the existing broken-on-smp
> config option. This is just the first pass, marking the obvious
> candidates.

When I had this problem in the past I just used && !64BIT.
How is this new option different?
> config ISDN_CAPI_CAPI20
> tristate "CAPI2.0 /dev/capi support"
> - depends on ISDN_CAPI
> + depends on ISDN_CAPI && BROKEN_ON_64BIT
> help
> This option will provide the CAPI 2.0 interface to userspace
> applications via /dev/capi20. Applications should use the
> @@ -44,7 +44,7 @@ config ISDN_CAPI_CAPIFS
>
> config ISDN_CAPI_CAPIDRV
> tristate "CAPI2.0 capidrv interface support"
> - depends on ISDN_CAPI && ISDN_I4L
> + depends on ISDN_CAPI && ISDN_I4L && BROKEN_ON_64BIT

As discussed earlier ISDN is actually ok.
> diff --git a/drivers/message/i2o/Kconfig b/drivers/message/i2o/Kconfig
> index 6443392..0e135ce 100644
> --- a/drivers/message/i2o/Kconfig
> +++ b/drivers/message/i2o/Kconfig
> @@ -56,7 +56,7 @@ config I2O_EXT_ADAPTEC_DMA64
>
> config I2O_CONFIG
> tristate "I2O Configuration support"
> - depends on I2O
> + depends on I2O && BROKEN_ON_64BIT
> ---help---
> Say Y for support of the configuration interface for the I2O adapters.

AFAIK I2O got fixed too. Do you have any evidence that it is really
broken on 64bit?

-Andi