From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Matthew Wilcox <matthew@wil.cx>
Cc: akpm@osdl.org, James.Bottomley@HansenPartnership.com,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH]: Switch fdomain to the pci_get API
Date: Mon, 16 Oct 2006 18:08:54 +0100 [thread overview]
Message-ID: <1161018534.24237.126.camel@localhost.localdomain> (raw)
In-Reply-To: <20061016162050.GF22289@parisc-linux.org>
Ar Llu, 2006-10-16 am 10:20 -0600, ysgrifennodd Matthew Wilcox:
> On Mon, Oct 16, 2006 at 04:55:46PM +0100, Alan Cox wrote:
> > + if (PCI_bus)
> > + pci_dev_put(PCI_dev);
>
> shirley 'if (PCI_dev)'?
No
The PCI_bus flag tells us that the hardware found and uses a PCI device,
which means PCI_dev holds a valid value (or NULL) which can and should
be passed to pci_dev_put.
Don't blame me I didn't write the driver ;)
Alan
prev parent reply other threads:[~2006-10-16 16:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-16 15:55 [PATCH]: Switch fdomain to the pci_get API Alan Cox
2006-10-16 16:20 ` Matthew Wilcox
2006-10-16 17:08 ` Alan Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1161018534.24237.126.camel@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=James.Bottomley@HansenPartnership.com \
--cc=akpm@osdl.org \
--cc=linux-scsi@vger.kernel.org \
--cc=matthew@wil.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox