From: James Bottomley <James.Bottomley@SteelEye.com>
To: Vasily Averin <vvs@sw.ru>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-scsi@vger.kernel.org, "Ju, Seokmann" <Seokmann.Ju@lsil.com>,
Andrew Morton <akpm@osdl.org>, Linus Torvalds <torvalds@osdl.org>,
devel@openvz.org, Andrey Mirkin <amirkin@sw.ru>
Subject: Re: [PATCH 2.6.19-rc2] scsi: megaraid_{mm,mbox}: 64-bit DMA capability fix
Date: Mon, 16 Oct 2006 14:34:44 -0500 [thread overview]
Message-ID: <1161027285.3433.25.camel@mulgrave.il.steeleye.com> (raw)
In-Reply-To: <45333E0B.7000905@sw.ru>
On Mon, 2006-10-16 at 12:08 +0400, Vasily Averin wrote:
> It is known that 2 LSI Logic MegaRAID SATA RAID Controllers (150-4 and 150-6)
> don't support 64-bit DMA. Unfortunately currently this check is wrong and driver
> sets 64-bit DMA mode for these devices.
>
> Signed-off-by: Andrey Mirkin <amirkin@sw.ru>
> Ack-by: Vasily Averin <vvs@sw.ru>
>
> --- linux-2.6.19-rc2/drivers/scsi/megaraid/megaraid_mbox.c.mgst6 2006-10-16
> 10:26:50.000000000 +0400
> +++ linux-2.6.19-rc2/drivers/scsi/megaraid/megaraid_mbox.c 2006-10-16
> 11:30:55.000000000 +0400
> @@ -884,7 +884,7 @@ megaraid_init_mbox(adapter_t *adapter)
>
> if (((magic64 == HBA_SIGNATURE_64_BIT) &&
> ((adapter->pdev->subsystem_device !=
> - PCI_SUBSYS_ID_MEGARAID_SATA_150_6) ||
> + PCI_SUBSYS_ID_MEGARAID_SATA_150_6) &&
> (adapter->pdev->subsystem_device !=
> PCI_SUBSYS_ID_MEGARAID_SATA_150_4))) ||
> (adapter->pdev->vendor == PCI_VENDOR_ID_LSI_LOGIC &&
Er ... this patch would apply in reverse, but what's in the tree
currently looks to be correct.
James
next prev parent reply other threads:[~2006-10-16 19:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-16 8:08 [PATCH 2.6.19-rc2] scsi: megaraid_{mm,mbox}: 64-bit DMA capability fix Vasily Averin
2006-10-16 19:34 ` James Bottomley [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-10-16 12:32 Ju, Seokmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1161027285.3433.25.camel@mulgrave.il.steeleye.com \
--to=james.bottomley@steeleye.com \
--cc=Seokmann.Ju@lsil.com \
--cc=akpm@osdl.org \
--cc=amirkin@sw.ru \
--cc=devel@openvz.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=torvalds@osdl.org \
--cc=vvs@sw.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox