From: James Bottomley <James.Bottomley@SteelEye.com>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: Andy Warner <andyw@pobox.com>, Mark Rustad <mrustad@mac.com>,
"Darrick J. Wong" <djwong@us.ibm.com>,
linux-scsi <linux-scsi@vger.kernel.org>,
Alexis Bruemmer <alexisb@us.ibm.com>,
Mike Anderson <andmike@us.ibm.com>
Subject: Re: [PATCH] libsas: support NCQ for SATA disks
Date: Mon, 16 Oct 2006 18:34:08 -0500 [thread overview]
Message-ID: <1161041648.3433.40.camel@mulgrave.il.steeleye.com> (raw)
In-Reply-To: <4533FAE4.3010601@pobox.com>
On Mon, 2006-10-16 at 17:34 -0400, Jeff Garzik wrote:
> As an aside, please clean up that magic number by assigning it a named
> constant (suggest SATA_FIS_H2D_REG) in include/linux/ata.h.
Fine by me ... I thought there would be one, but libata-core also uses
the hex value. Why don't you put it in and I'll convert aic94xx
over ... that way we don't get into any cross tree dependencies?
James
next prev parent reply other threads:[~2006-10-16 23:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-13 23:56 [PATCH] libsas: support NCQ for SATA disks Darrick J. Wong
2006-10-15 17:42 ` James Bottomley
2006-10-15 18:43 ` Darrick J. Wong
2006-10-15 19:42 ` Luben Tuikov
2006-10-16 1:27 ` Mark Rustad
2006-10-16 1:49 ` Andy Warner
2006-10-16 2:22 ` Luben Tuikov
2006-10-16 18:25 ` James Bottomley
2006-10-16 21:34 ` Jeff Garzik
2006-10-16 23:34 ` James Bottomley [this message]
2006-10-16 22:40 ` Brian King
2006-10-17 11:15 ` Jeff Garzik
2006-10-17 16:35 ` James Bottomley
2006-10-17 22:42 ` Luben Tuikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1161041648.3433.40.camel@mulgrave.il.steeleye.com \
--to=james.bottomley@steeleye.com \
--cc=alexisb@us.ibm.com \
--cc=andmike@us.ibm.com \
--cc=andyw@pobox.com \
--cc=djwong@us.ibm.com \
--cc=jgarzik@pobox.com \
--cc=linux-scsi@vger.kernel.org \
--cc=mrustad@mac.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox