From: James Bottomley <James.Bottomley@SteelEye.com>
To: malahal@us.ibm.com
Cc: linux-scsi@vger.kernel.org
Subject: Re: [PATCH] AIC94XX: call tasklet_kill while unloading the module
Date: Thu, 19 Oct 2006 14:57:19 -0400 [thread overview]
Message-ID: <1161284239.11219.19.camel@mulgrave.il.steeleye.com> (raw)
In-Reply-To: <20061019032551.GB19570@us.ibm.com>
On Wed, 2006-10-18 at 20:25 -0700, malahal@us.ibm.com wrote:
> Signed-off-by: Malahal Naineni <malahal@us.ibm.com>
>
> diff -r d134b26a8da8 drivers/scsi/aic94xx/aic94xx_init.c
> --- a/drivers/scsi/aic94xx/aic94xx_init.c Wed Oct 18 16:34:30 2006 -0700
> +++ b/drivers/scsi/aic94xx/aic94xx_init.c Wed Oct 18 18:21:40 2006 -0700
> @@ -737,6 +737,11 @@ static void __devexit asd_pci_remove(str
> /* XXX more here as needed */
>
> free_irq(dev->irq, asd_ha);
> +
> + /* We already disabled interrupts and freed the IRQ. Now, it is
> + * safe to kill the tasklet that processes done list */
> + tasklet_kill(&asd_ha->seq.dl_tasklet);
> +
Actually, this should be in asd_destroy_ha_caches() which is where the
asd_init_hw() teardown path is ... not that I'm very happy with this;
the teardown should be in aic94xx_hwi.c where the init path is ...
James
next prev parent reply other threads:[~2006-10-19 18:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-19 3:25 [PATCH] AIC94XX: call tasklet_kill while unloading the module malahal
2006-10-19 18:57 ` James Bottomley [this message]
2006-10-19 22:02 ` malahal
2006-10-19 22:10 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1161284239.11219.19.camel@mulgrave.il.steeleye.com \
--to=james.bottomley@steeleye.com \
--cc=linux-scsi@vger.kernel.org \
--cc=malahal@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox