From: James Bottomley <James.Bottomley@SteelEye.com>
To: dougg@torque.net
Cc: Stefan Richter <stefanr@s5r6.in-berlin.de>,
Joern Quillman <quillman@fbihome.de>,
linux-scsi@vger.kernel.org
Subject: Re: Spinup of SCSI Disks: allow_restart won't work on 2.6.18
Date: Mon, 20 Nov 2006 22:20:50 -0600 [thread overview]
Message-ID: <1164082850.2816.125.camel@mulgrave.il.steeleye.com> (raw)
In-Reply-To: <45624E30.5080605@torque.net>
On Mon, 2006-11-20 at 19:54 -0500, Douglas Gilbert wrote:
> ... but why have the condition at all? What other peripheral
> device type should the _sd_ driver be handling??
The original patch was for some IBM ipr array that behaves stupidly and
requires a START_UNIT after a reset. I suspect this was the reason the
type check was in there. However, if there's a use for this outside the
particular array, then it should be taken out.
Note that there may be a bit of work necessary to make this function for
USB: it's keyed to the standard response CC/UA/LOGICAL UNIT NOT READY,
INITIALIZING COMMAND REQUIRED. Since USB devices aren't necessarily
standards compliant in this regard, simply setting the bit may not work.
James
next prev parent reply other threads:[~2006-11-21 4:22 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-17 17:38 Spinup of SCSI Disks: allow_restart won't work on 2.6.18 Joern Quillman
2006-11-17 21:44 ` Joern Quillmann
2006-11-17 23:34 ` Stefan Richter
2006-11-17 23:36 ` Stefan Richter
2006-11-20 10:52 ` Joern Quillman
2006-11-20 11:48 ` Stefan Richter
2006-11-20 22:32 ` Joern Quillman
2006-11-20 23:53 ` Stefan Richter
2006-11-21 0:54 ` Douglas Gilbert
2006-11-21 4:20 ` James Bottomley [this message]
2006-11-21 8:12 ` Stefan Richter
2006-11-21 14:41 ` Brian King
2006-11-21 20:34 ` [PATCH] scsi: sd: configurable allow_restart attribute for all device types Stefan Richter
2006-11-21 1:09 ` Spinup of SCSI Disks: allow_restart won't work on 2.6.18 Joern Quillmann
2006-11-21 20:49 ` Stefan Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1164082850.2816.125.camel@mulgrave.il.steeleye.com \
--to=james.bottomley@steeleye.com \
--cc=dougg@torque.net \
--cc=linux-scsi@vger.kernel.org \
--cc=quillman@fbihome.de \
--cc=stefanr@s5r6.in-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox