From: James Bottomley <James.Bottomley@SteelEye.com>
To: Andy Whitcroft <apw@shadowen.org>
Cc: linux-scsi@vger.kernel.org, Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH] scsi_device_put unused variable module without CONFIG_MODULE_UNLOAD
Date: Wed, 22 Nov 2006 09:15:27 -0600 [thread overview]
Message-ID: <1164208527.2785.6.camel@mulgrave.il.steeleye.com> (raw)
In-Reply-To: <5b8c107f6d06b70065ca44309be0dcbf@pinky>
On Wed, 2006-11-22 at 14:39 +0000, Andy Whitcroft wrote:
> scsi_device_put: unused variable module without CONFIG_MODULE_UNLOAD
>
> When CONFIG_MODULE_UNLOAD is not defined then the module variable
> in scsi_device_put() becomes unused resulting in the warnings below.
> Move this inside the existing #ifdef.
>
> .../drivers/scsi/scsi.c:883: warning: unused variable 'module'
Actually, the fix for this is already in scsi-misc, so it should be
making its way into -mm.
James
prev parent reply other threads:[~2006-11-22 15:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-22 14:39 [PATCH] scsi_device_put unused variable module without CONFIG_MODULE_UNLOAD Andy Whitcroft
2006-11-22 15:15 ` James Bottomley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1164208527.2785.6.camel@mulgrave.il.steeleye.com \
--to=james.bottomley@steeleye.com \
--cc=akpm@osdl.org \
--cc=apw@shadowen.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox