From: James Bottomley <James.Bottomley@SteelEye.com>
To: Henne <henne@nachtwindheim.de>
Cc: Andrew Morton <akpm@osdl.org>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH]: scsi: in2000 scsi_cmnd convertion
Date: Fri, 24 Nov 2006 17:01:43 -0600 [thread overview]
Message-ID: <1164409303.2813.21.camel@mulgrave.il.steeleye.com> (raw)
In-Reply-To: <45659882.1060201@nachtwindheim.de>
On Thu, 2006-11-23 at 13:48 +0100, Henne wrote:
> - volatile Scsi_Cmnd *input_Q; /* commands waiting to be started */
> - volatile Scsi_Cmnd *selecting; /* trying to select this command */
> - volatile Scsi_Cmnd *connected; /* currently connected command */
> - volatile Scsi_Cmnd *disconnected_Q;/* commands waiting for reconnect */
> + volatile struct scsi_cmnd *input_Q;
> + /* commands waiting to be started */
> + volatile struct scsi_cmnd *selecting;
> + /* trying to select this command */
> + volatile struct scsi_cmnd *connected;
> + /* currently connected command */
> + volatile struct scsi_cmnd *disconnected_Q;
This doesn't preserve the indentation of the original.
Plus, I think if you lose the volatile then a lot of pointless casts
like this one:
> - tmp = (Scsi_Cmnd *) hostdata->input_Q;
> + tmp = (struct scsi_cmnd *) hostdata->input_Q;
Can be eliminated entirely (its sole job is to drop the volatile again).
James
prev parent reply other threads:[~2006-11-24 23:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-23 12:48 [PATCH]: scsi: in2000 scsi_cmnd convertion Henne
2006-11-24 23:01 ` James Bottomley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1164409303.2813.21.camel@mulgrave.il.steeleye.com \
--to=james.bottomley@steeleye.com \
--cc=akpm@osdl.org \
--cc=henne@nachtwindheim.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox