From: Ben Collins <ben.collins@ubuntu.com>
To: James Bottomley <James.Bottomley@SteelEye.com>
Cc: Randy Dunlap <randy.dunlap@oracle.com>,
scsi <linux-scsi@vger.kernel.org>, akpm <akpm@osdl.org>
Subject: Re: [PATCH] scsi/initio: section mismatches with HOTPLUG=n
Date: Fri, 24 Nov 2006 18:10:59 -0500 [thread overview]
Message-ID: <1164409859.5257.7.camel@gullible> (raw)
In-Reply-To: <1164408696.2813.19.camel@mulgrave.il.steeleye.com>
On Fri, 2006-11-24 at 16:51 -0600, James Bottomley wrote:
> On Sun, 2006-11-19 at 18:53 -0800, Randy Dunlap wrote:
> > From: Randy Dunlap <randy.dunlap@oracle.com>
> >
> > WARNING: drivers/scsi/initio.o - Section mismatch: reference to .init.data: from .text between 'i91u_detect' (at offset 0x26e8) and 'i91uSCBPost'
> > WARNING: drivers/scsi/initio.o - Section mismatch: reference to .init.data:i91u_pci_devices from .text between 'i91u_detect' (at offset 0x26ef) and 'i91uSCBPost'
>
> Hmm, this apparently got into the tree unreviewed via Ben Collins:
>
> commit 012887327875915f76a6208e81fe0d67a682ec15
> Author: Ben Collins <bcollins@ubuntu.com>
> Date: Wed Oct 18 08:40:57 2006 -0400
>
> [initio] Add pci dev table for module auto loading.
>
> Signed-off-by: Ben Collins <bcollins@ubuntu.com>
>
> Ben, for future reference, would you send SCSI patches over the SCSI
> list, please. Secondly, do you intend to complete this change? What
> Randy proposes will restore the driver to its original state. However,
> it could also be fixed properly by adding __devinit to all the relevant
> PCI initialisation routines, which would be preferable.
The patch went in with about half a dozen others for similar changes, so
it was a group set.
Sorry about the mismatches. I've only been building with HOTPLUG=y.
I can do a patch if you want, just let me know.
next prev parent reply other threads:[~2006-11-24 23:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-20 2:53 [PATCH] scsi/initio: section mismatches with HOTPLUG=n Randy Dunlap
2006-11-24 22:51 ` James Bottomley
2006-11-24 23:10 ` Ben Collins [this message]
2006-11-25 15:19 ` James Bottomley
2006-11-25 17:19 ` Ben Collins
2006-11-25 17:37 ` James Bottomley
2006-11-26 16:02 ` Ben Collins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1164409859.5257.7.camel@gullible \
--to=ben.collins@ubuntu.com \
--cc=James.Bottomley@SteelEye.com \
--cc=akpm@osdl.org \
--cc=linux-scsi@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox