public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Ben Collins <ben.collins@ubuntu.com>
To: James Bottomley <James.Bottomley@SteelEye.com>
Cc: Randy Dunlap <randy.dunlap@oracle.com>,
	scsi <linux-scsi@vger.kernel.org>, akpm <akpm@osdl.org>
Subject: Re: [PATCH] scsi/initio: section mismatches with HOTPLUG=n
Date: Sat, 25 Nov 2006 12:19:56 -0500	[thread overview]
Message-ID: <1164475196.5257.105.camel@gullible> (raw)
In-Reply-To: <1164467971.2804.3.camel@mulgrave.il.steeleye.com>

On Sat, 2006-11-25 at 09:19 -0600, James Bottomley wrote:
> On Fri, 2006-11-24 at 18:10 -0500, Ben Collins wrote:
> > The patch went in with about half a dozen others for similar changes, so
> > it was a group set.
> > 
> > Sorry about the mismatches. I've only been building with HOTPLUG=y.
> > 
> > I can do a patch if you want, just let me know.
> 
> Well, I was sort of hoping you weren't just randomly introducing
> __devinitdata but had all the necessary support patches for converting
> the driver to hotplug.  However, if that's not the case, the safest
> thing to do is remove the section annotation ... I don't think anyone
> cares enough about this driver to convert it fully and test it.

The MODULE_DEV_TABLE was added so userspace has an easier time loading a
driver for the device, without special rules. It wasn't meant to make
the driver hot-pluggable. I think the idea that a module alias is just
for hotplug is a little short-sighted.

  reply	other threads:[~2006-11-25 17:20 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-20  2:53 [PATCH] scsi/initio: section mismatches with HOTPLUG=n Randy Dunlap
2006-11-24 22:51 ` James Bottomley
2006-11-24 23:10   ` Ben Collins
2006-11-25 15:19     ` James Bottomley
2006-11-25 17:19       ` Ben Collins [this message]
2006-11-25 17:37         ` James Bottomley
2006-11-26 16:02           ` Ben Collins

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1164475196.5257.105.camel@gullible \
    --to=ben.collins@ubuntu.com \
    --cc=James.Bottomley@SteelEye.com \
    --cc=akpm@osdl.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=randy.dunlap@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox