Re: [PATCH] scsi/initio: section mismatches with HOTPLUG=n

Ben Collins
2006-11-25T17:20:04Z

On Sat, 2006-11-25 at 09:19 -0600, James Bottomley wrote:
> On Fri, 2006-11-24 at 18:10 -0500, Ben Collins wrote:
> > The patch went in with about half a dozen others for similar changes, so
> > it was a group set.
> >
> > Sorry about the mismatches. I've only been building with HOTPLUG=y.
> >
> > I can do a patch if you want, just let me know.
>
> Well, I was sort of hoping you weren't just randomly introducing
> __devinitdata but had all the necessary support patches for converting
> the driver to hotplug. However, if that's not the case, the safest
> thing to do is remove the section annotation ... I don't think anyone
> cares enough about this driver to convert it fully and test it.

The MODULE_DEV_TABLE was added so userspace has an easier time loading a
driver for the device, without special rules. It wasn't meant to make
the driver hot-pluggable. I think the idea that a module alias is just
for hotplug is a little short-sighted.