From: James Bottomley <James.Bottomley@SteelEye.com>
To: Ben Collins <ben.collins@ubuntu.com>
Cc: Randy Dunlap <randy.dunlap@oracle.com>,
scsi <linux-scsi@vger.kernel.org>, akpm <akpm@osdl.org>
Subject: Re: [PATCH] scsi/initio: section mismatches with HOTPLUG=n
Date: Sat, 25 Nov 2006 11:37:50 -0600 [thread overview]
Message-ID: <1164476271.2804.11.camel@mulgrave.il.steeleye.com> (raw)
In-Reply-To: <1164475196.5257.105.camel@gullible>
On Sat, 2006-11-25 at 12:19 -0500, Ben Collins wrote:
> The MODULE_DEV_TABLE was added so userspace has an easier time loading
> a
> driver for the device, without special rules. It wasn't meant to make
> the driver hot-pluggable. I think the idea that a module alias is just
> for hotplug is a little short-sighted.
The module device table isn't the problem. The problem is the fact that
you marked the table __devinitdata. __devinitdata is a sectional
marking that causes the table to be placed in a discardable init data
section for CONFIG_HOTPLUG=n. However, the routines accessing it still
occur in the standard text segment hence the mismatch. If you want to
mark data __devinitdata, you have to ensure that all the routines
accessing it are marked __devinit.
James
next prev parent reply other threads:[~2006-11-25 17:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-20 2:53 [PATCH] scsi/initio: section mismatches with HOTPLUG=n Randy Dunlap
2006-11-24 22:51 ` James Bottomley
2006-11-24 23:10 ` Ben Collins
2006-11-25 15:19 ` James Bottomley
2006-11-25 17:19 ` Ben Collins
2006-11-25 17:37 ` James Bottomley [this message]
2006-11-26 16:02 ` Ben Collins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1164476271.2804.11.camel@mulgrave.il.steeleye.com \
--to=james.bottomley@steeleye.com \
--cc=akpm@osdl.org \
--cc=ben.collins@ubuntu.com \
--cc=linux-scsi@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox