Re: [PATCH] scsi/initio: section mismatches with HOTPLUG=n

Ben Collins
2006-11-26T16:02:57Z

On Sat, 2006-11-25 at 11:37 -0600, James Bottomley wrote:
> On Sat, 2006-11-25 at 12:19 -0500, Ben Collins wrote:
> > The MODULE_DEV_TABLE was added so userspace has an easier time loading
> > a
> > driver for the device, without special rules. It wasn't meant to make
> > the driver hot-pluggable. I think the idea that a module alias is just
> > for hotplug is a little short-sighted.
>
> The module device table isn't the problem. The problem is the fact that
> you marked the table __devinitdata. __devinitdata is a sectional
> marking that causes the table to be placed in a discardable init data
> section for CONFIG_HOTPLUG=n. However, the routines accessing it still
> occur in the standard text segment hence the mismatch. If you want to
> mark data __devinitdata, you have to ensure that all the routines
> accessing it are marked __devinit.

I know what the section is :) I wasn't aware that it was causing a
problem with HOTPLUG=n. I'll get a patch to fix it up.