Re: [PATCH] scsi/initio: section mismatches with HOTPLUG=n

Ben Collins
2006-11-24T23:11:07Z

On Fri, 2006-11-24 at 16:51 -0600, James Bottomley wrote:
> On Sun, 2006-11-19 at 18:53 -0800, Randy Dunlap wrote:
> > From: Randy Dunlap <randy.dunlap@oracle.com>
> >
> > WARNING: drivers/scsi/initio.o - Section mismatch: reference to .init.data: from .text between 'i91u_detect' (at offset 0x26e8) and 'i91uSCBPost'
> > WARNING: drivers/scsi/initio.o - Section mismatch: reference to .init.data:i91u_pci_devices from .text between 'i91u_detect' (at offset 0x26ef) and 'i91uSCBPost'
>
> Hmm, this apparently got into the tree unreviewed via Ben Collins:
>
> commit 012887327875915f76a6208e81fe0d67a682ec15
> Author: Ben Collins <bcollins@ubuntu.com>
> Date: Wed Oct 18 08:40:57 2006 -0400
>
> [initio] Add pci dev table for module auto loading.
>
> Signed-off-by: Ben Collins <bcollins@ubuntu.com>
>
> Ben, for future reference, would you send SCSI patches over the SCSI
> list, please. Secondly, do you intend to complete this change? What
> Randy proposes will restore the driver to its original state. However,
> it could also be fixed properly by adding __devinit to all the relevant
> PCI initialisation routines, which would be preferable.

The patch went in with about half a dozen others for similar changes, so
it was a group set.

Sorry about the mismatches. I've only been building with HOTPLUG=y.

I can do a patch if you want, just let me know.