From: michaelc@cs.wisc.edu
To: linux-scsi@vger.kernel.org
Cc: Arne Redlich <agr@powerkom-dd.de>,
Arne Redlich <arne.redlich@xiranet.com>,
Mike Christie <michaelc@cs.wisc.edu>
Subject: [PATCH 1/5] fix 2.6.19 data digest calculation bug
Date: Sun, 17 Dec 2006 12:10:24 -0600 [thread overview]
Message-ID: <1166379028772-git-send-email-michaelc@cs.wisc.edu> (raw)
From: Arne Redlich <agr@powerkom-dd.de>
The transition from crypto_digest_*() to the crypto_hash_*() family
introduced a bug into the data digest calculation: crypto_hash_update() is
called with the number of S/G elements instead of the S/G lists data size.
Signed-off-by: Arne Redlich <arne.redlich@xiranet.com>
-
Signed-off-by: Mike Christie <michaelc@cs.wisc.edu>
---
drivers/scsi/iscsi_tcp.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/scsi/iscsi_tcp.c b/drivers/scsi/iscsi_tcp.c
index d0b139c..61e3a61 100644
--- a/drivers/scsi/iscsi_tcp.c
+++ b/drivers/scsi/iscsi_tcp.c
@@ -749,7 +749,7 @@ static int iscsi_scsi_data_in(struct isc
if (!offset)
crypto_hash_update(
&tcp_conn->rx_hash,
- &sg[i], 1);
+ &sg[i], sg[i].length);
else
partial_sg_digest_update(
&tcp_conn->rx_hash,
--
1.4.1.1
next reply other threads:[~2006-12-17 18:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-17 18:10 michaelc [this message]
2006-12-17 18:10 ` [PATCH 2/5] iscsi: fix crypto_alloc_hash() error check michaelc
2006-12-17 18:10 ` [PATCH 3/5] newline in iscsi printk michaelc
2006-12-17 18:10 ` [PATCH 4/5] IPv6 and Linux iSCSI initiator michaelc
2006-12-17 18:10 ` [PATCH 5/5] libiscsi: fix senselen calculation michaelc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1166379028772-git-send-email-michaelc@cs.wisc.edu \
--to=michaelc@cs.wisc.edu \
--cc=agr@powerkom-dd.de \
--cc=arne.redlich@xiranet.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox