From: James Bottomley <James.Bottomley@SteelEye.com>
To: Eric Moore <eric.moore@lsil.com>
Cc: linux-scsi@vger.kernel.org
Subject: Re: [PATCH 2/5] fusion: vmware bug fix prevent inifinite retries
Date: Sat, 06 Jan 2007 09:30:45 -0600 [thread overview]
Message-ID: <1168097445.2792.53.camel@mulgrave.il.steeleye.com> (raw)
In-Reply-To: <20070105034613.GA14118@lsil.com>
On Thu, 2007-01-04 at 20:46 -0700, Eric Moore wrote:
> - if (scsi_status == MPI_SCSI_STATUS_BUSY)
> + if (ioc->bus_type != SPI && scsi_status == MPI_SCSI_STATUS_BUSY)
> sc->result = (DID_BUS_BUSY << 16) | scsi_status;
> else
> sc->result = (DID_OK << 16) | scsi_status;
DID_BUS_BUSY causes an immediate retry, but it does debit the retry
count, so it shouldn't cause "infinite retries" ... if it does, there's
something else wrong here.
I should also point out that the MPI_SCSI_STATUS_BUSY is
SAM_STAT_BUSY ... this return will cause a queue stop and a requeue, but
it doesn't actually debit the retries, so it *may* cause an infinite
loop if the system is permanently busy.
Finally, whatever's causing this, it should probably be treated the same
for all fusion bus types ...
James
next prev parent reply other threads:[~2007-01-06 15:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-05 3:46 [PATCH 2/5] fusion: vmware bug fix prevent inifinite retries Eric Moore
2007-01-06 15:30 ` James Bottomley [this message]
2007-01-06 16:10 ` Matthew Wilcox
2007-01-06 16:28 ` James Bottomley
-- strict thread matches above, loose matches on Subject: below --
2007-01-08 22:03 Moore, Eric
2007-01-08 22:24 ` James Bottomley
2007-01-09 1:37 Moore, Eric
2007-01-09 16:17 ` Michael Reed
2007-01-09 17:49 ` Manon Goo
2007-01-09 18:14 Adam Zimman
2007-01-09 20:55 ` Petr Vandrovec
2007-01-09 21:32 ` Edward Goggin
2007-01-10 16:10 ` James Bottomley
2007-01-10 16:44 ` Edward Goggin
2007-01-10 5:44 Moore, Eric
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1168097445.2792.53.camel@mulgrave.il.steeleye.com \
--to=james.bottomley@steeleye.com \
--cc=eric.moore@lsil.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox