Re: [PATCH 2/5] scsi: megaraid_sas - added bios_param in scsi_host_template

Andrew Morton
2007-02-07T21:19:56Z

On Tue, 06 Feb 2007 13:57:23 -0800
Sumant Patro <sumantp@lsil.com> wrote:

> +static int
> +megasas_bios_param(struct scsi_device *sdev, struct block_device *bdev,
> + sector_t capacity, int geom[])
> +{
> + int heads;
> + int sectors;
> + sector_t cylinders;
> + ulong dummy;

Plain old `unsigned long' is preferred.

> + /* Default heads (64) & sectors (32) */
> + heads = 64;
> + sectors = 32;
> +
> + dummy = heads * sectors;
> + cylinders = capacity;
> +
> + sector_div(cylinders, dummy);
> +
> + /*
> + * Handle extended translation size for logical drives > 1Gb
> + */
> +
> + if ((ulong)capacity >= 0x200000) {

Here we're casting a sector_t down to a 32-bit number. Are you sure that
`capacity' here can never exceed 0xffffffff?