Re: [PATCH] drivers/scsi/aic7xxx_old: Convert to generic boolean-values

Richard Knutsson
2007-02-10T20:35:29Z

James Bottomley wrote:
> On Sat, 2007-02-10 at 18:46 +0100, Richard Knutsson wrote:
>
>> Convert:
>> FALSE -> false
>> TRUE -> true
>>
>
> Actually, downcasing true and false in this driver is pretty much a
> retrograde step. The reason for their being uppercased is that they
> represent constants (and uppercase is the traditional defined constant
> specifier).
>
I would argue that 'false' and 'true' are values and not constants, but
further more C99 is defining them in lowercase (stdbool.h).
> When discussion about TRUE and FALSE came up a long time a go in the
> context of the mid layer we agreed to strip the defined constants out of
> that code and just go with 1 and 0 inline ... because the code was
> pretty much being rewritten. We also decided to encourage but not force
> the driver writers simply to use 1 and 0 as well ... a lot of people are
> deeply wedded to the TRUE and FALSE defines, it turned out.
>
As I have expressed before, I don't understand why people seem to
dislike 'false'/'true' but anyway, since you seem to approve booleans,
would it be possible to convert the obvious variables/functions into
boolean-type?

Richard Knutsson